From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C53C4BA09 for ; Wed, 26 Feb 2020 02:56:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 768A021927 for ; Wed, 26 Feb 2020 02:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="u21uYTjY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Moy0oe77" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 768A021927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BA8E8166D; Wed, 26 Feb 2020 03:55:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BA8E8166D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582685800; bh=vpJBftnch6W0aZBcY1dGEjiFTFvs9+NIOhP7Gerzqh8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=u21uYTjY9aoFC1S/aSqv/Tvu5UA06MAcydEQZUcz2Tbe4ImO37xMyQKnikDqSHUP+ 5Tqg3/NOmm0GOTv2SQLqXp33tKa5vpZaVljvhgviy8Lo7I5ikPS6WI2wDWrJXUiKTw 8LVdWhVxUe54HkDmrn//B9EuEi3sss+BA8wagklo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2CF3AF8014D; Wed, 26 Feb 2020 03:55:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B4C5EF800E8; Wed, 26 Feb 2020 03:55:48 +0100 (CET) Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EE4C0F800E8 for ; Wed, 26 Feb 2020 03:55:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EE4C0F800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Moy0oe77" Received: by mail-pj1-x1041.google.com with SMTP id d5so615242pjz.5 for ; Tue, 25 Feb 2020 18:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bfSVMJ6Zntz6A9BJaM12dNm4EQGGybEoHbVncbTsUMA=; b=Moy0oe77F1nP33WomY+/yVeQF9YOUm9A+K2Dmya3vWO3y1gDf7kXx+ARQoGIqJsbcn sPDlocDXHhiYZjO+XyXUp5tQV8BJw2C7x+2ghY8gYyPWFQ7qduGfKCkjbgpdinZcGNjB WxhCMHnCKG0c8t5hywtULwpBqj4C0bP6PHBAoxnZH9WUICVJuyrYV1mqj2wAShGjfCs6 tIJzuV4Fe3jr6nyPLQ/HjFbLHYzt3rgUTWbLX8hMswIRiB57T3uJgkHbl/XIWiXtE5Fv PNehsU30K6Pj2wGG2X6MPSgieuIgHYhU1Oya8m/3JHtMlRpQXMzTlhwP7/IXW+Pi/+xR gauw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bfSVMJ6Zntz6A9BJaM12dNm4EQGGybEoHbVncbTsUMA=; b=fovchjIPxow7FOUunHC36jPrJ9U1GX67WEmjl2myxinXF+f7QGYPC8YY9NUYIUuPUo UOklJgZM34+UIxICzAhBlHRaArbMslbrqHWpuKeIyElb9fk0GmPTx94dchBrpRVcGzPb znWMssUaynOsaZw8CI5cRrdS1sM6mPMVl963tGqeUn/GjWnJ/1U9zBAvV3efA0XERsuU EukOQ7rGxWtuJk/2laxvA4fRv5o5xS+oCXq/3YW4zX669cD891LjWufTDrbh4ZDuBaJh 8GdB3ncpJewtqv+bNIWBjFKdGpcpQw6phZp7eTTpY/Pp2eLKmkTIXn8w0Oft3TZZXT/L 5w9w== X-Gm-Message-State: APjAAAWuXshR0Fq4DV1rlvgdwzBTwdJ/D6cjIfCNFUAx4ny/AnBMHieo uTuuKC/Y+UTA+ltgYmt3yLs= X-Google-Smtp-Source: APXvYqxX5rlyRMCuaRBBYuYMduxdjpm5x24xmrS5n9R3CJux7Jc4o6x9N7kxgP+pNGY/fDI9hDV73g== X-Received: by 2002:a17:902:9f88:: with SMTP id g8mr1790693plq.100.1582685743306; Tue, 25 Feb 2020 18:55:43 -0800 (PST) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id l13sm444798pjq.23.2020.02.25.18.55.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Feb 2020 18:55:43 -0800 (PST) Date: Tue, 25 Feb 2020 18:55:40 -0800 From: Nicolin Chen To: Shengjiu Wang Subject: Re: [PATCH v2 3/3] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers Message-ID: <20200226025540.GA22445@Asurada-Nvidia.nvidia.com> References: <20200225080350.GA11332@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , "timur@kernel.org" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "S.j. Wang" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Feb 26, 2020 at 09:51:39AM +0800, Shengjiu Wang wrote: > > > > > +static const struct regmap_config fsl_easrc_regmap_config = { > > > > > + .readable_reg = fsl_easrc_readable_reg, > > > > > + .volatile_reg = fsl_easrc_volatile_reg, > > > > > + .writeable_reg = fsl_easrc_writeable_reg, > > > > > > > > Can we use regmap_range and regmap_access_table? > > > > > > > > > > Can the regmap_range support discontinuous registers? The > > > reg_stride = 4. > > > > I think it does. Giving an example here: > > https://github.com/torvalds/linux/blob/master/drivers/mfd/da9063-i2c.c > > The register in this i2c driver are continuous, from 0x00, 0x01, 0x02... > > But our case is 0x00, 0x04, 0x08, does it work? Ah...I see your point now. I am not very sure -- have only used in I2C drivers. You can ignore if it doesn't likely work for us.