From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A5A8C4BA0A for ; Wed, 26 Feb 2020 08:04:34 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEB3D21556 for ; Wed, 26 Feb 2020 08:04:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RocxWRjT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HiIPJH7s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEB3D21556 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F0B9C1670; Wed, 26 Feb 2020 09:03:41 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F0B9C1670 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582704272; bh=/8t0g2cxqXTJyaSIWZzEhRM2DXny7j7hDf1vOZK9bSU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RocxWRjT8i/34RnDII0wIrvWLOdxc16Y8ry8+5+gVLbTOP2jmAWOHdHxYR5hs43Za 5AniVev6TtdTay1R35cxYSFUW4RBdiWIEoqEgcn14aDMxfGtFu2cS6eGNrp4cBVv4Z 7wFQu3EPSAZG1RbGlts2lUlQPjNoUQt5WQKicnZw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7017DF8014D; Wed, 26 Feb 2020 09:03:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1274F8014E; Wed, 26 Feb 2020 09:03:38 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B4E21F800E8 for ; Wed, 26 Feb 2020 09:03:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B4E21F800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HiIPJH7s" Received: from localhost (unknown [171.76.87.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA92721556; Wed, 26 Feb 2020 08:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582704212; bh=/8t0g2cxqXTJyaSIWZzEhRM2DXny7j7hDf1vOZK9bSU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HiIPJH7s2e5kx9X+3AsYHSq7Gp7jbchemi90DNr/a0jDz2Ri5gxPNfYgfYe8Gk7VK Upx82x+THPhCVcP9cGtrlvkarYuU6Yd/FkKr0sq+RWeShX72+stYtuEQd95T2acb4u 72v+jwV1rgAv5NUs98rgBzfI4KKBB986M6Mfaimc= Date: Wed, 26 Feb 2020 13:33:26 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [PATCH] soundwire: bus: provide correct return value on error Message-ID: <20200226080326.GU2618@vkoul-mobl> References: <20200225164907.23358-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200225164907.23358-1-pierre-louis.bossart@linux.intel.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 25-02-20, 10:49, Pierre-Louis Bossart wrote: > From: Bard Liao > > It seems to be a typo. It makes more sense to return the return value > of sdw_update() instead of the value we want to update. > > Signed-off-by: Bard Liao > Signed-off-by: Pierre-Louis Bossart > --- > drivers/soundwire/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c > index 13887713f311..b8a7a84aca1c 100644 > --- a/drivers/soundwire/bus.c > +++ b/drivers/soundwire/bus.c > @@ -1070,7 +1070,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave) > if (ret < 0) { > dev_err(slave->bus->dev, > "SDW_DP0_INTMASK read failed:%d\n", ret); > - return val; > + return ret; good catch. But can we optimize it to: > } > > return 0; make this as below and remove the return above. return ret; > -- > 2.20.1 -- ~Vinod