From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35CEFC4BA10 for ; Wed, 26 Feb 2020 12:27:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B35F324685 for ; Wed, 26 Feb 2020 12:27:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="RUb/PuJm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B35F324685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F220D1655; Wed, 26 Feb 2020 13:26:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F220D1655 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582720039; bh=VPJngg7C2avbMeb4L65drmcQvZ+4VqbZDWVG175EJMw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RUb/PuJmX+C1I8mysUQxGXpP0o0EJP82V6qIyncTIN9yuWmirbLEnKGpNOyYSKFml +I0SIADypO9QdVadIZBANjRt+tmgHWHXs4rDihcQSesIgLMBnLXfZgJjKJ97JHW5+M Cbozs/ADyB5jALdvAN+IDQaMyxn5FKVYHItaWaFM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A373F8014D; Wed, 26 Feb 2020 13:26:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 07167F8014E; Wed, 26 Feb 2020 13:26:26 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id 0AAEFF800AD for ; Wed, 26 Feb 2020 13:26:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0AAEFF800AD Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A6291FB; Wed, 26 Feb 2020 04:26:21 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 92A363FA00; Wed, 26 Feb 2020 04:26:20 -0800 (PST) Date: Wed, 26 Feb 2020 12:26:19 +0000 From: Mark Brown To: jack.yu@realtek.com Subject: Re: [PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai Message-ID: <20200226122619.GF4136@sirena.org.uk> References: <20200226022827.3262-1-jack.yu@realtek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lIrNkN/7tmsD/ALM" Content-Disposition: inline In-Reply-To: <20200226022827.3262-1-jack.yu@realtek.com> X-Cookie: May all your PUSHes be POPped. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, lars@metafoo.de, kent_chen@realtek.com, kenny_chen@realtek.com, lgirdwood@gmail.com, derek.fang@realtek.com, shumingf@realtek.com, mingjane_hsieh@realtek.com, flove@realtek.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --lIrNkN/7tmsD/ALM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 26, 2020 at 10:28:27AM +0800, jack.yu@realtek.com wrote: > From: Jack Yu >=20 > 1. Add "static" for rt1015_aif_dai_ops. > 2. Add "static" for rt1015_dai[]. > 3. Add operation callback for rt1015_dai[]. Please don't send multiple changes in a single patch, split them up into separate patches - the callback certainly seems like it needs to be in a different patch. > @@ -664,7 +664,7 @@ static int rt1015_hw_params(struct snd_pcm_substream = *substream, > snd_soc_component_update_bits(component, RT1015_TDM_MASTER, > RT1015_I2S_DL_MASK, val_len); > snd_soc_component_update_bits(component, RT1015_CLK2, > - RT1015_FS_PD_MASK, pre_div); > + RT1015_FS_PD_MASK, pre_div << RT1015_FS_PD_SFT); > =20 > return 0; > } This doesn't seem to be mentioned in the changelog and should probably also be a separate patch? --lIrNkN/7tmsD/ALM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5WY+oACgkQJNaLcl1U h9DsWwf/dQs3poLbJP9axq+2cvAoRIyxFY8WC88OOIVrhUISwukxxqKurxx1aBgi u7A8/WqTFpjxMjxhcnvzqkgVJjE/XK9Qzt8ffDSw/NuEyhpwJcJSSAzx9vfOshRm /792hgCFcAQ4MSzLrw5LBkKhvlpjaZ+injT42QZSvk6mWHI3WQXsKxiLZALS+HIt fi6t3ML+GYdzpiHFPyWF4WDIRgA6YFy18z+u4vO9G/sA/yUNz2VyPHI1tWS+3udr DEyTjwKsRtroqaj8N84D1QjOrmF40jZqTmf5oiYa4gig//efZxSwILL7IhVBR7N6 xBHGM4m9ZSE1SpM8iiBBXSyeU1ppRA== =jZrK -----END PGP SIGNATURE----- --lIrNkN/7tmsD/ALM--