Re: [alsa-devel] [RFC PATCH 04/34] ASoC: sun8i-codec: Remove unused dev from codec struct

Mark Brown
2020-02-17T15:05:43Z

[-- Attachment #1.1: Type: text/plain, Size: 520 bytes --]

On Mon, Feb 17, 2020 at 12:42:20AM -0600, Samuel Holland wrote:
> This field is not used anywhere in the driver, so remove it.

> Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec")

This is in no way a bug fix, it's a random cleanup. This means that the
Fixes tag isn't really appropriate and it should be done after the
subsequent changes in the series that fix real bugs. You should always
put bug fixes first so that they don't have any unneeded depenencies on
other things and can be merged without them.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]