From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 141FFC3F2D3 for ; Fri, 28 Feb 2020 15:49:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9053F2469D for ; Fri, 28 Feb 2020 15:49:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="MMy1g02A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9053F2469D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DC8DC16D4; Fri, 28 Feb 2020 16:48:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DC8DC16D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582904947; bh=Oy2ldJn4Mh6A6U9cW0jozVZjlJ2RPb9dnTRhitgLVgk=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=MMy1g02Aq2nSRm1id9dQz6RCK2508kdIs8f9aJLLoVIJUL/YaQbkvTAagvtvkpcgc er59/R0byckD57v5ngQgkKMaJdrQ5YneHEJLx4rDTBjIvMzJ84lnIn9NJaBRiWJZjq YkAuWzfqGZQoXc/uevPY0uIjADNXkI0Youiv7Lgk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 57A12F8014D; Fri, 28 Feb 2020 16:48:16 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87727F8014E; Fri, 28 Feb 2020 16:48:15 +0100 (CET) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D2ADBF80113 for ; Fri, 28 Feb 2020 16:48:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D2ADBF80113 Received: by mail-ot1-f68.google.com with SMTP id x97so2977103ota.6 for ; Fri, 28 Feb 2020 07:48:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=04LO6bJs9Ua8w0YW0IQRrzZktCzF8p2YIFQW4LHwyB0=; b=VcsrAJX3MqonwSVm5qsoLXe512GjY859auzQuFVTC6ElGWYAM6YvysnAMKMXPFmiPe Hc23frArgKrANN+4dVg5QfXMYARPO36rla2KykgQgmefTfGosL1H//m2/esLPzLtAtCq CRCFdAdsbzSUUEgyOk1jo6r05sktNqbBPi7V+ubRjMB5U6LUpYSVsxexkA2ktQu6p4ef ZYnnmKYuX48C8Fy0gCZTLbic6pxfFyyrf8bqwDD+CQ4ZcAj8fzAip0gkh9mviQTdk4Eh DCWm5uquzRk8aWv6Pu4TqVmGof8CagiolEGE9qCdXvZ4ZfZVrIebrf9atNhcow3U3zxh 4ShQ== X-Gm-Message-State: APjAAAUCkFdPp1qQwD/TUZc6Sr4GgqZ93sS+NxsP8Pil7ykcHO32ptgR W8HIvJB7yYJLih1Ogr3B7A== X-Google-Smtp-Source: APXvYqwV+P2KDc8CtB9VtadeSMw2dPxupLHtu2jRnsumBHTjh6d8J/zLIoII9iqRfrM9E79eDylpmg== X-Received: by 2002:a05:6830:150:: with SMTP id j16mr3791728otp.301.1582904887823; Fri, 28 Feb 2020 07:48:07 -0800 (PST) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k201sm3273559oih.43.2020.02.28.07.48.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 07:48:07 -0800 (PST) Received: (nullmailer pid 24254 invoked by uid 1000); Fri, 28 Feb 2020 15:48:06 -0000 Date: Fri, 28 Feb 2020 09:48:06 -0600 From: Rob Herring To: Jerome Brunet Subject: Re: [PATCH 1/9] ASoC: meson: gx-card: fix sound-dai dt schema Message-ID: <20200228154806.GA19636@bogus> References: <20200224145821.262873-1-jbrunet@baylibre.com> <20200224145821.262873-2-jbrunet@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224145821.262873-2-jbrunet@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Kevin Hilman , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-amlogic@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Feb 24, 2020 at 03:58:13PM +0100, Jerome Brunet wrote: > There is a fair amount of warnings when running 'make dtbs_check' with > amlogic,gx-sound-card.yaml. > > Ex: > arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0:1: missing phandle tag in 0 > arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0:2: missing phandle tag in 0 > arch/arm64/boot/dts/amlogic/meson-gxm-q200.dt.yaml: sound: dai-link-0:sound-dai:0: [66, 0, 0] is too long > > The reason is that the sound-dai phandle provided has cells, and in such > case the schema should use 'phandle-array' instead of 'phandle', even if > the property expects a single phandle. > > Fixes: fd00366b8e41 ("ASoC: meson: gx: add sound card dt-binding documentation") > Signed-off-by: Jerome Brunet > --- > Hi Mark, > > The statement above is based on this LKML discussion I found: > https://lkml.org/lkml/2019/9/30/382 > > To be honest, I don't really get why the consumer should know whether > the phandle will have cells or not. AFAIK, the consumer does not care > about this ... Yeah, I think another type definition is needed here to distinguish between a single phandle+args and an array of phandle+args. In any case, Acked-by: Rob Herring > > .../devicetree/bindings/sound/amlogic,gx-sound-card.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)