From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FAKE_REPLY_C,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B54EFC3F2CD for ; Wed, 4 Mar 2020 13:45:44 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B1762146E for ; Wed, 4 Mar 2020 13:45:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="KJo8fZ7u"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sty86Vgj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B1762146E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A2DBA1607; Wed, 4 Mar 2020 14:44:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A2DBA1607 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583329542; bh=jdTUtZCeADw4iFzCvLuSOdsEnfJb9E0SIWAQY6oL210=; h=Date:From:To:Subject:In-Reply-To:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=KJo8fZ7uhIKgRfbhrBReNpW6d09lOdC5eQ8afxm8nflmjY4t2wf1eh6UcWtac9Ykq IBbScdgse891xlMcGYIWSENnL6VQEtg85QhAkKJTOywM9FILev2nUdquUSo+E0wuUI 4DdmNGmgfAKkrzhqhK8Fy0OzIyPssnuaAZOzpSOc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1854BF801EC; Wed, 4 Mar 2020 14:44:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B151F801ED; Wed, 4 Mar 2020 14:44:50 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5C29AF800D8 for ; Wed, 4 Mar 2020 14:44:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5C29AF800D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sty86Vgj" Received: from localhost (173-25-83-245.client.mchsi.com [173.25.83.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E8A52166E; Wed, 4 Mar 2020 13:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583329485; bh=jdTUtZCeADw4iFzCvLuSOdsEnfJb9E0SIWAQY6oL210=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sty86VgjWMYbLJNmBzBXyiSMF/i3BdVPFIxs11zNEI6cgDn8K87vzpw5fHgdUq+dz +XyL0uG0QmUwVedBDhYOWwShe/8e7SkMsRfEz8dAA6+/+Dd4NfpF0lLLIpIfRXa1U9 DCjV7Kpo3yeFsYZWF2kEQjvt8ATA4sML11v2Ctk8= Date: Wed, 4 Mar 2020 07:44:44 -0600 From: Bjorn Helgaas To: Heiner Kallweit Subject: Re: [PATCH v4 09/10] PCI: pci-bridge-emul: Use new constant PCI_STATUS_ERROR_BITS Message-ID: <20200304134444.GA198415@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04851614-b906-2b1b-f937-189c3c210880@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Cc: alsa-devel@alsa-project.org, Realtek linux nic maintainers , "linux-pci@vger.kernel.org" , Clemens Ladisch , Takashi Iwai , Stephen Hemminger , "netdev@vger.kernel.org" , David Miller , Linux Kernel Mailing List , Mirko Lindner X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Feb 29, 2020 at 11:28:18PM +0100, Heiner Kallweit wrote: > Use new constant PCI_STATUS_ERROR_BITS to simplify the code. > > Signed-off-by: Heiner Kallweit Acked-by: Bjorn Helgaas > --- > drivers/pci/pci-bridge-emul.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c > index fffa77093..4f4f54bc7 100644 > --- a/drivers/pci/pci-bridge-emul.c > +++ b/drivers/pci/pci-bridge-emul.c > @@ -50,12 +50,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = { > (PCI_STATUS_CAP_LIST | PCI_STATUS_66MHZ | > PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MASK) << 16), > .rsvd = GENMASK(15, 10) | ((BIT(6) | GENMASK(3, 0)) << 16), > - .w1c = (PCI_STATUS_PARITY | > - PCI_STATUS_SIG_TARGET_ABORT | > - PCI_STATUS_REC_TARGET_ABORT | > - PCI_STATUS_REC_MASTER_ABORT | > - PCI_STATUS_SIG_SYSTEM_ERROR | > - PCI_STATUS_DETECTED_PARITY) << 16, > + .w1c = PCI_STATUS_ERROR_BITS << 16, > }, > [PCI_CLASS_REVISION / 4] = { .ro = ~0 }, > > @@ -100,12 +95,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = { > PCI_STATUS_DEVSEL_MASK) << 16) | > GENMASK(11, 8) | GENMASK(3, 0)), > > - .w1c = (PCI_STATUS_PARITY | > - PCI_STATUS_SIG_TARGET_ABORT | > - PCI_STATUS_REC_TARGET_ABORT | > - PCI_STATUS_REC_MASTER_ABORT | > - PCI_STATUS_SIG_SYSTEM_ERROR | > - PCI_STATUS_DETECTED_PARITY) << 16, > + .w1c = PCI_STATUS_ERROR_BITS << 16, > > .rsvd = ((BIT(6) | GENMASK(4, 0)) << 16), > }, > -- > 2.25.1 > >