From: Mark Brown <broonie@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: jack.yu@realtek.com, alsa-devel@alsa-project.org,
cychiang@google.com, lgirdwood@gmail.com, derek.fang@realtek.com,
shumingf@realtek.com, flove@realtek.com
Subject: Re: [v2 3/3] ASoC: rt5682: Add the descriptions for the DMIC clock rate and delay settings
Date: Thu, 19 Mar 2020 12:35:19 +0000 [thread overview]
Message-ID: <20200319123519.GA3983@sirena.org.uk> (raw)
In-Reply-To: <20200319074328.25284-3-oder_chiou@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
On Thu, Mar 19, 2020 at 03:43:28PM +0800, Oder Chiou wrote:
> +- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
> + particular DMIC.
Lars mentioned on the previous version that this should have units on it
so -hz (I assume, perhaps the unit is different) here. As he said it'd
also be a bit more idiomatic to say clock rather than clk.
> +- realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of
> + the particular DMIC.
This change is good though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-19 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 7:43 [v2 1/3] ASoC: rt5682: Add a property for DMIC clock rate setting Oder Chiou
2020-03-19 7:43 ` [v2 2/3] ASoC: rt5682: Add a property for DMIC delay Oder Chiou
2020-03-19 7:43 ` [v2 3/3] ASoC: rt5682: Add the descriptions for the DMIC clock rate and delay settings Oder Chiou
2020-03-19 12:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319123519.GA3983@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cychiang@google.com \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox