From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E3FC4332E for ; Mon, 23 Mar 2020 12:19:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1757720637 for ; Mon, 23 Mar 2020 12:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="s2JWu8gW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PI/1uCxo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1757720637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6C9F4886; Mon, 23 Mar 2020 13:18:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6C9F4886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584965959; bh=hxcrz2tO+N8anTbgxKJo/lWuzhD01NFnXAyUAjiHza4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s2JWu8gWyNJPk6plcrlNZwWMMuVqmH/MOhMGqrA8d2cd7TAFoKoWzqb+9A8cN7t50 ljc0XE9v0+vs/79NqdMCNjzeXRUz9FZl1xJx9iSqjHeMAvCUJWEgaiVpARBfXJbHcA kEFtOYBQVI9IOBJM8lq42dV5x69qihAdrzGm3KJ4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EDFAAF80147; Mon, 23 Mar 2020 13:18:28 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BE0EFF80158; Mon, 23 Mar 2020 13:18:26 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 10043F800F6 for ; Mon, 23 Mar 2020 13:18:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 10043F800F6 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PI/1uCxo" Received: from localhost (unknown [122.178.205.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E63E520788; Mon, 23 Mar 2020 12:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584965901; bh=hxcrz2tO+N8anTbgxKJo/lWuzhD01NFnXAyUAjiHza4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PI/1uCxozIzKRx7vhHJPe0CsTSpO3XsKw9Sgd+LFaJn3Ln0JiFczyNebpU4XmLahd 9k2Jsj9Y9e6Vi6VVRWE8rmYkHk7u/wYVR2cGXT9q7MejalmAbv5lilBEiRO4MKJcu9 rTiJ3RLUkcFlToDqkbg1zA0SKTiB/OAXgLwUGy1Q= Date: Mon, 23 Mar 2020 17:48:17 +0530 From: Vinod Koul To: Pierre-Louis Bossart Subject: Re: [PATCH 3/7] soundwire: intel: add mutex to prevent concurrent access to SHIM registers Message-ID: <20200323121817.GK72691@vkoul-mobl> References: <20200311221026.18174-1-pierre-louis.bossart@linux.intel.com> <20200311221026.18174-4-pierre-louis.bossart@linux.intel.com> <20200320134112.GC4885@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 20-03-20, 09:07, Pierre-Louis Bossart wrote: > > > > diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h > > > index 38b7c125fb10..568c84a80d79 100644 > > > --- a/drivers/soundwire/intel.h > > > +++ b/drivers/soundwire/intel.h > > > @@ -15,6 +15,7 @@ > > > * @irq: Interrupt line > > > * @ops: Shim callback ops > > > * @dev: device implementing hw_params and free callbacks > > > + * @shim_lock: mutex to handle access to shared SHIM registers > > > */ > > > struct sdw_intel_link_res { > > > struct platform_device *pdev; > > > @@ -25,6 +26,7 @@ struct sdw_intel_link_res { > > > int irq; > > > const struct sdw_intel_ops *ops; > > > struct device *dev; > > > + struct mutex *shim_lock; /* protect shared registers */ > > > > Where is this mutex initialized? Did you test this... > > Dude, we've been testing the heck out of SoundWire. > > If you want to see the actual initialization it's in the intel_init.c code: > > https://github.com/thesofproject/linux/blob/9c7487b33072040ab755d32ca173b75151c0160c/drivers/soundwire/intel_init.c#L231 Which doesn't make much sense. A patch should do complete thing. I don't see a reason why you cannot pull this single line into this patch. It belongs here, not anywhere else. -- ~Vinod