From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C236EC43331 for ; Thu, 2 Apr 2020 11:59:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CBE520757 for ; Thu, 2 Apr 2020 11:59:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="OS9NMk4U" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CBE520757 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 96D531670; Thu, 2 Apr 2020 13:59:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 96D531670 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585828790; bh=2UP7n2mD95XrWlIJhQaSK9X/Izc0emgUzPHy+6sen2c=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OS9NMk4U6C6ST6RMITquMt7V8jf2B0aODMpc5w5nTY1xMd/HP6cvbZe2OxfTBZdgl gVBkDyb/mxRfNAM+lZlZNk/UTk670bAFAwr87ZDUT1t9xcjx7Rx4sZY5l4+4mq/2Yu tpg1+ppw/5fMbLsKXt2rkSlWvDgc6655k1mFait4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 115FFF80141; Thu, 2 Apr 2020 13:59:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 59235F80148; Thu, 2 Apr 2020 13:58:58 +0200 (CEST) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 17C1AF80141 for ; Thu, 2 Apr 2020 13:58:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 17C1AF80141 X-Originating-IP: 86.202.105.35 Received: from localhost (lfbn-lyo-1-9-35.w86-202.abo.wanadoo.fr [86.202.105.35]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AE629C0007; Thu, 2 Apr 2020 11:58:51 +0000 (UTC) Date: Thu, 2 Apr 2020 13:58:51 +0200 From: Alexandre Belloni To: Tang Bin Subject: Re: [PATCH] ALSA:atmel:Use platform_get_irq_optional() Message-ID: <20200402115851.GG3683@piout.net> References: <20200402112135.18604-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200402112135.18604-1-tangbin@cmss.chinamobile.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com, tiwai@suse.com, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 02/04/2020 19:21:35+0800, Tang Bin wrote: > In order to simply code,because platform_get_irq() already has > dev_err() message. > But what I see is a dev_dbg message so your patch actually changes the behaviour when debugging is not enabled. > Signed-off-by: Tang Bin > --- > sound/atmel/ac97c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index a1dce9725..25cfd5710 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -715,7 +715,7 @@ static int atmel_ac97c_probe(struct platform_device *pdev) > return -ENXIO; > } > > - irq = platform_get_irq(pdev, 0); > + irq = platform_get_irq_optional(pdev, 0); > if (irq < 0) { > dev_dbg(&pdev->dev, "could not get irq: %d\n", irq); > return irq; > -- > 2.20.1.windows.1 > > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com