From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FDBDC2BA19 for ; Sun, 12 Apr 2020 02:16:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A40B820787 for ; Sun, 12 Apr 2020 02:16:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="e2ZzNEQP"; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="qALFqVq0"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oavigFNj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A40B820787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CC0BE16AC; Sun, 12 Apr 2020 04:15:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CC0BE16AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586657768; bh=EEHYfC3QVqBgPYFIpPaM4xk0P9ZeUlvaHRgj8SMQfAA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e2ZzNEQPI3TOU7o8K4pySBIByxPS4SzVq7Z8PHQ0odlPuyc2TfeS7LhhzAEUBhlOm sKt07vlETXfZOJOu5tP6a6/rsAtX77+6CPYdgeagtqMzLF8UuUCnrPZlqHwpbqKZoV 7Cw4om37v/7rabDFeIqg0CnlLDTeqFod185gI02Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 43BD8F800B9; Sun, 12 Apr 2020 04:15:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86AD8F8013D; Sun, 12 Apr 2020 04:15:16 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EF131F800B9 for ; Sun, 12 Apr 2020 04:15:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EF131F800B9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="qALFqVq0"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="oavigFNj" Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 315755C01A0; Sat, 11 Apr 2020 22:15:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 11 Apr 2020 22:15:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=CQqaW6cieUAJsGP1GU0t9wHxBY5 azeWDjcNm2ZKqVX0=; b=qALFqVq06cM9t+URCua8Ugzw13EGa+/R/UwIyGhszZG SD2Q+L0J/QHWGVuk4AbARhWDEfmu+0jZGf1k0Fq6l78jlh+KOCBA0wXWnO/++eqy 7xBCkq1Pq8eJ3NU2SWIdltF6oI4FnUYyG606RSfUM70wsEJs9ora5ewEj54fykzT wmAKM+/2NezkUXsnkIz4Yh7aIAq7i4kewvK1THQfLCTyJm20eArbOcCPPobmm3Ce Snv6/qTUCL1hA3Mg5SIOOwHZy+4J3CyDJuAFKd5+3DBQ03OcRpPlHLDIswqqNnzd PryDAPoqLWuHvNESj181mf6ZK+2L9xgoFMCAHlqpf4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CQqaW6 cieUAJsGP1GU0t9wHxBY5azeWDjcNm2ZKqVX0=; b=oavigFNjxa5x2+3kQFmbcA UPtbwXtT6svNRyk/kx7MR6ultf4mhhF18u4+MahSvaqZYswLrAHfTzMpykC7l257 jWg+krTts5Ytyqf35W30QbB/8ulOJrOsSl8O0/l5l/LV51F3thNs/OMlqRBqVguz kctSucZzjyhrxQ3d7us9QcvJM86UpVXgOZbmVptiyT/lJ4eKfXuD09vHfr5AvFCJ /uiaiNHhLoZ22z5/9x8Hztek8p9y3m+kOEz9vsrqKo/CM57iVu6+8EqYpTQvZoKt EBXVfgjI1NoBhqGH6sNPZbuCN9xaUmjJuzqT6sWuVN+/VTduP94+I4RgXgrDdaLg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrvdehgdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesthdtre dttdervdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgrkhgr shhhihesshgrkhgrmhhotggthhhirdhjpheqnecukfhppedugedrfedrkedvrdduuddune cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgr khgrshhhihesshgrkhgrmhhotggthhhirdhjph X-ME-Proxy: Received: from workstation (ae082111.dynamic.ppp.asahi-net.or.jp [14.3.82.111]) by mail.messagingengine.com (Postfix) with ESMTPA id C8673328006A; Sat, 11 Apr 2020 22:15:04 -0400 (EDT) Date: Sun, 12 Apr 2020 11:15:00 +0900 From: Takashi Sakamoto To: Zev Weiss Subject: Re: [PATCH] alsactl: don't exit on EINTR from epoll_wait(). Message-ID: <20200412021457.GA3961@workstation> Mail-Followup-To: Zev Weiss , alsa-devel@alsa-project.org References: <20191015043650.23536-1-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015043650.23536-1-zev@bewilderbeest.net> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Oct 14, 2019 at 11:36:50PM -0500, Zev Weiss wrote: > Previously, things like attaching strace to a running 'alsactl monitor' > process would cause it to exit. > > Signed-off-by: Zev Weiss > --- > alsactl/monitor.c | 2 ++ > 1 file changed, 2 insertions(+) I'm sorry but I overlooked the post. It looks good to me. Reviewed-by: Takashi Sakamoto Tested-by: Takashi Sakamoto > diff --git a/alsactl/monitor.c b/alsactl/monitor.c > index 6b090e4f5c92..cf4167bee165 100644 > --- a/alsactl/monitor.c > +++ b/alsactl/monitor.c > @@ -342,6 +342,8 @@ static int run_dispatcher(int epfd, int sigfd, int infd, struct list_head *srcs, > > count = epoll_wait(epfd, epev, max_ev_count, 200); > if (count < 0) { > + if (errno == EINTR) > + continue; > err = count; > break; > } > -- > 2.23.0 Regards Takashi Sakamoto