From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7610C2BA19 for ; Wed, 15 Apr 2020 20:44:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41B3B20732 for ; Wed, 15 Apr 2020 20:44:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="HENIBF6o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RisHhF3j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41B3B20732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9DB031697; Wed, 15 Apr 2020 22:44:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9DB031697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1586983491; bh=F3qZyBdt2Xx1NwEP6uSq60pJt8B7zrWHn0GD/ylers8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HENIBF6ohyils9XO5hvZqtKkyzE9ZL3eLRMXHYYZxHjiXENimKsWPrVabqgKDK8Cq WOMeSkMMaFm4OnzucQHdS2680k0ga1G9fx1QHMEGHpJ9FkOi+7t1WkcIFYp/wB2ehG 6iBrom3Ai1wm7VsaiYVh8CfbsojifY+uTwCrt9pc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 209E9F80229; Wed, 15 Apr 2020 22:39:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E4DF8F80245; Wed, 15 Apr 2020 22:39:27 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D9862F80115 for ; Wed, 15 Apr 2020 22:39:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D9862F80115 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RisHhF3j" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AA6120787; Wed, 15 Apr 2020 20:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586983162; bh=F3qZyBdt2Xx1NwEP6uSq60pJt8B7zrWHn0GD/ylers8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RisHhF3jA6l7pk2/1o4KS7ZVzduaO9wpuoTq4cpb1LqSFRrPVk2cxGA3ebcru1oLg vTmRqcRDblI5UfRiOpU257GuoDjSId0OmwBRigzMPdHnOshL0vp0PGtHYdDstGUru5 ZjymD2Yc1OOWIhyTR2vtky9zew687ZvpEpHTs9zo= Date: Wed, 15 Apr 2020 21:39:20 +0100 From: Mark Brown To: Pierre-Louis Bossart Subject: Re: [RFC PATCH 02/16] ASoC: pcm512x: use "sclk" string to retrieve clock Message-ID: <20200415203920.GN5265@sirena.org.uk> References: <20200414182728.GM5412@sirena.org.uk> <3017b762-7a0c-cee2-06dd-1e96f52eb849@linux.intel.com> <20200414195031.GP5412@sirena.org.uk> <0d2aed9b-5c79-9ed2-6ca1-67b2688e4c99@linux.intel.com> <20200415113630.GC5265@sirena.org.uk> <4635e57b-fccd-d8a9-fa99-8124debb3428@linux.intel.com> <20200415162247.GF5265@sirena.org.uk> <9a7fbbac-818a-01d0-7a32-8ae313f9ad50@linux.intel.com> <20200415195033.GL5265@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="prC3/KjdfqNV7evK" Content-Disposition: inline In-Reply-To: X-Cookie: Hire the morally handicapped. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Matthias Reichl , tiwai@suse.de, Linus Walleij , Stephen Boyd , Daniel Matuschek , linux-clk@vger.kernel.org, Hui Wang , linux-gpio@vger.kernel.org, Rob Herring , Bartosz Golaszewski , Andy Shevchenko , Michael Turquette X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --prC3/KjdfqNV7evK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 15, 2020 at 03:22:50PM -0500, Pierre-Louis Bossart wrote: > > In the case of this driver could you look at registering the link from > > the device for the clocks? Have it say "I supply SCK on device X" as it > > registers. That should be fairly straightforward I think, we do that > > for one of the regulators. > When you wrote 'in the case of this driver', were you referring to the clock > provider, saying 'I support SCK on device i2c-104C5122:00' ? Yes. > If you have a pointer on the regulator example, I'd appreciate it, I am > really way beyond my comfort zone. The arizona driver is what I was thinking of, that's more complex than you proabably need as it's a MFD. > Maybe an alternate suggestion if you want to avoid hard-coded strings in the > kernel: what if we added optional properties for the clock lookup name in > both the codec and clock driver, and set the name in a _DSD blob. That would > move the platform-specific names to platform firmware, and avoid the links > described above that are probably ACPI-only. If you read the lookup information from firmware somehow that's probably fine I think. It's not nice but if it's baked into firmware... > > I think by now there's ample evidence that it's worth investing in > > better firmware descriptions :( > Indeed, and tools to check they are correct! Most of the stuff we defined > for SoundWire ends-up wrong or undefined, still an uphill battle... The audio-graph-card appears to be working really well FWIW, Morimoto-san did an excellent job there. --prC3/KjdfqNV7evK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6XcPcACgkQJNaLcl1U h9CebAf6A48V9aus+H7FxEuq8AB7bAyf63kZiGZv2wSHn2LPeRtdM3Gq+gQ8DX9B ABou4ScgfHuBiZJgP6/CXeSIJDoyRSvrMWyv/RkGa9Dunj+THYuMATPnC9lDZYPt mNV/3tTBBOBajXwJgkMKw3lGnUz9o2BaQeiWBYin8LH0SpqddEn5ORv5Jv2Pf4CN dNhyO1C8Bfd1aUhhUzmLQwvkh9WU7hRPutGJMcj1Ygf3ayRFUTHV8txS1d8ikEi6 2wi8zeIhgpgK4G4WUxgLUbT4kj1zqV3ZAPEaz9ALlh8Fy7EctSi8tFeAWCZMETX/ Kli2fIRNAisVjMywH3V0NtxEI/MVxA== =uaKf -----END PGP SIGNATURE----- --prC3/KjdfqNV7evK--