From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
Allison Randal <allison@lohutok.net>
Subject: [PATCH] ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats()
Date: Wed, 22 Apr 2020 12:22:55 +0300 [thread overview]
Message-ID: <20200422092255.GB195357@mwanda> (raw)
This should be ARRAY_SIZE() instead of sizeof(). The sizeof() limit is
too high so it doesn't work.
Fixes: 093b8494f299 ("ALSA: usb-audio: Print more information in stream proc files")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/usb/proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/usb/proc.c b/sound/usb/proc.c
index 5a36e192ebb0..889c550c9f29 100644
--- a/sound/usb/proc.c
+++ b/sound/usb/proc.c
@@ -140,7 +140,7 @@ static void proc_dump_substream_formats(struct snd_usb_substream *subs, struct s
snd_iprintf(buffer, " Channel map:");
for (c = 0; c < map->channels; c++) {
- if (map->map[c] >= sizeof(channel_labels) ||
+ if (map->map[c] >= ARRAY_SIZE(channel_labels) ||
!channel_labels[map->map[c]])
snd_iprintf(buffer, " --");
else
--
2.26.1
next reply other threads:[~2020-04-22 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 9:22 Dan Carpenter [this message]
2020-04-22 9:29 ` [PATCH] ALSA: usb-audio: Fix a limit check in proc_dump_substream_formats() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422092255.GB195357@mwanda \
--to=dan.carpenter@oracle.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox