From: Alexander Tsoy <alexander@tsoy.me>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>, Gregor Pintar <grpintar@gmail.com>,
Roope Salmi <rpsalmi@gmail.com>
Subject: [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen
Date: Fri, 24 Apr 2020 05:24:49 +0300 [thread overview]
Message-ID: <20200424022449.14972-2-alexander@tsoy.me> (raw)
In-Reply-To: <20200424022449.14972-1-alexander@tsoy.me>
Frame size computation has been fixed and the workaround is no longer
needed.
Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
---
sound/usb/quirks.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 351ba214a9d3..a8ece1701068 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1806,20 +1806,6 @@ void snd_usb_audioformat_attributes_quirk(struct snd_usb_audio *chip,
*/
fp->attributes &= ~UAC_EP_CS_ATTR_FILL_MAX;
break;
- case USB_ID(0x1235, 0x8200): /* Focusrite Scarlett 2i4 2nd gen */
- case USB_ID(0x1235, 0x8202): /* Focusrite Scarlett 2i2 2nd gen */
- case USB_ID(0x1235, 0x8205): /* Focusrite Scarlett Solo 2nd gen */
- /*
- * Reports that playback should use Synch: Synchronous
- * while still providing a feedback endpoint.
- * Synchronous causes snapping on some sample rates.
- * Force it to use Synch: Asynchronous.
- */
- if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
- fp->ep_attr &= ~USB_ENDPOINT_SYNCTYPE;
- fp->ep_attr |= USB_ENDPOINT_SYNC_ASYNC;
- }
- break;
}
}
--
2.26.2
next prev parent reply other threads:[~2020-04-24 2:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 2:24 [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Alexander Tsoy
2020-04-24 2:24 ` Alexander Tsoy [this message]
2020-04-24 6:28 ` [PATCH 2/2] ALSA: usb-audio: Remove async workaround for Scarlett 2nd gen Takashi Iwai
2020-04-24 15:21 ` Gregor Pintar
2020-04-24 6:28 ` [PATCH 1/2] ALSA: usb-audio: Improve frames size computation Takashi Iwai
2020-04-24 9:19 ` Pavel Hofman
2020-04-24 9:29 ` Alexander Tsoy
2020-04-24 9:39 ` Pavel Hofman
2020-04-24 15:02 ` Gregor Pintar
2020-04-24 16:43 ` Alexander Tsoy
2020-04-25 16:50 ` Gregor Pintar
2020-04-25 18:09 ` Gregor Pintar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424022449.14972-2-alexander@tsoy.me \
--to=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=grpintar@gmail.com \
--cc=rpsalmi@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox