From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F62C2BA1A for ; Fri, 24 Apr 2020 09:32:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E57A20736 for ; Fri, 24 Apr 2020 09:32:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="PJz6b7Nt"; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nuioZ6cr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E57A20736 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7078016C5; Fri, 24 Apr 2020 11:31:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7078016C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587720724; bh=ClZZ+zNkpZtjl/C5ITekfMDtYhjvWj1JuDvsxQceVy8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PJz6b7Nts2C4zWON2pi2mcI5hgOT0qK0QN+wfITcHMSY2pTv1Vd8We33oNDC1Oyqv aW3KB+dlDIGHEBkGKDaOL1kTCEuLhE7GvrVJVDQYv386L6QwJ7K8g+ViE6vqjQMCuC rd/dBDimqgDRayIKRfiRLgSIuxA9T3QrPGNZdPcY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48354F8020C; Fri, 24 Apr 2020 11:31:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 182E8F8021C; Fri, 24 Apr 2020 11:30:59 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B8765F801D9 for ; Fri, 24 Apr 2020 11:30:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B8765F801D9 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nuioZ6cr" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7CB420736; Fri, 24 Apr 2020 09:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587720654; bh=ClZZ+zNkpZtjl/C5ITekfMDtYhjvWj1JuDvsxQceVy8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nuioZ6crqRqT6ywAgGFJTNzf14utCcTkooewPUyM2jbEvgCeVwaoHTt2kqGLc55Dk HJdHGeWZJXe+SBkjS92Ji+6zGvpNeY3aVyCItYT9JfWiNiq8qnPyg5cTPV2PxRBv+j rgtIjRsKC3RqF3FppSYVnvN+FEsaHzWo4xX24mQY= Date: Fri, 24 Apr 2020 10:30:51 +0100 From: Mark Brown To: Kuninori Morimoto Subject: Re: [PATCH 02/17] ASoC: soc-dai: don't overwide dai->driver->ops Message-ID: <20200424093051.GA5850@sirena.org.uk> References: <871rofunaq.wl-kuninori.morimoto.gx@renesas.com> <87y2qnt8oy.wl-kuninori.morimoto.gx@renesas.com> <20200423150933.GO4808@sirena.org.uk> <874kt9u8qq.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <874kt9u8qq.wl-kuninori.morimoto.gx@renesas.com> X-Cookie: Information is the inverse of entropy. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 24, 2020 at 07:39:58AM +0900, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > Current ASoC overwides dai->driver->ops if it was NULL. > > > But, it is not good idea, because dai->driver might be reused > > > when modprobe/rmmod or bind/unbind, etc. > > This is fine but it's not a correctness issue since we're always filling > > the same value in - the big issue with putting stuff in structures is > > when you end up using the same struct for two different different things > > so you fill different values in. > I see. > But all my remaining patches are based on this patch, > and rebase without it seems very difficult. > So, I want to keep it. > v2 patchset still has it, but adds different git-log. Right, like I say the change is fine - it was just a note about the changelog. --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6isccACgkQJNaLcl1U h9Dspwf/V3LiqfaOGUfPzZWjuPUX43pGOfY/pR8SDStU9hU0UEbXfLpn6htXr2KQ 9DfGw9cbRlXX/2Qsjme/9BDJ0ExC/sOOLF3MLkP3zGw9rb9mzG5alXl/AMwDWOLc AAbXoh8vC1ZEgGa/yIW3LTeE1FfUAaamt6OF9Lto3WXaiDPVLM9PYNWocdsMkN/4 5D9xO09eVswe+vt+Fr1Hw8RgIpzP2pLoEeWBbVKrmZ3zZOmMPCXJgr4cUUafW9hx 7hAxSv2Km9qNMre5QiTjstZ8SfTK6AV1oem8qITCLgDVISWpxm4bsgaPV8klgCpA 00hik+YNLRWt5kvQQ0so0SZzHdh29g== =UJHo -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--