From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
Shengjiu Wang <shengjiu.wang@nxp.com>,
tiwai@suse.com, lgirdwood@gmail.com, tglx@linutronix.de,
info@metux.net, allison@lohutok.net
Subject: Re: [PATCH] ASoC: wm8962: Force suspend/resume during system suspend/resume
Date: Fri, 24 Apr 2020 11:46:46 +0100 [thread overview]
Message-ID: <20200424104646.GC5850@sirena.org.uk> (raw)
In-Reply-To: <20200424104347.GJ44490@ediswmail.ad.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Fri, Apr 24, 2020 at 10:43:47AM +0000, Charles Keepax wrote:
> intended to put the CODEC into runtime suspend. I am guessing the
> reason you have problems is because of the driver doing its own
> pm_runtime operations in set_fll, which probably takes an extra
> reference preventing the power down. Is a more complex fix
> correcting the interaction with DAPM the correct solution here?
Or just updating the machine driver to turn off the FLL when shutting
down (or even when the device is idle in general).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-04-24 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 6:12 [PATCH] ASoC: wm8962: Force suspend/resume during system suspend/resume Shengjiu Wang
2020-04-24 10:43 ` Charles Keepax
2020-04-24 10:46 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424104646.GC5850@sirena.org.uk \
--to=broonie@kernel.org \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=info@metux.net \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=shengjiu.wang@nxp.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox