From: Mark Brown <broonie@kernel.org>
To: Seven Lee <wtli@nuvoton.com>
Cc: YHCHuang@nuvoton.com, alsa-devel@alsa-project.org,
KCHSU0@nuvoton.com, lgirdwood@gmail.com, CTLIN0@nuvoton.com
Subject: Re: [PATCH] ASoc: nau8810: add AUX related dapm widgets and routes
Date: Fri, 24 Apr 2020 12:27:22 +0100 [thread overview]
Message-ID: <20200424112722.GE5850@sirena.org.uk> (raw)
In-Reply-To: <20200424071739.20854-1-wtli@nuvoton.com>
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
On Fri, Apr 24, 2020 at 03:17:40PM +0800, Seven Lee wrote:
> This patch implements the following features:
> - AUX input for recording.
> - An input AUX output to SPK/MOUT.
This fails to build with current code, please check and resend:
In file included from /mnt/kernel/sound/soc/codecs/nau8810.c:24:
/mnt/kernel/sound/soc/codecs/nau8810.c:359:3: error: 'NAU8810_AUXSPK_SFT' undeclared here (not in a function); did you mean 'NAU8810_DACSPK_SFT'?
NAU8810_AUXSPK_SFT, 1, 0),
^~~~~~~~~~~~~~~~~~
/mnt/kernel/include/sound/soc.h:33:39: note: in definition of macro 'SOC_DOUBLE_VALUE'
{.reg = xreg, .rreg = xreg, .shift = shift_left, \
^~~~~~~~~~
/mnt/kernel/include/sound/soc-dapm.h:293:19: note: in expansion of macro 'SOC_SINGLE_VALUE'
.private_value = SOC_SINGLE_VALUE(reg, shift, max, invert, 0) }
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-24 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 7:17 [PATCH] ASoc: nau8810: add AUX related dapm widgets and routes Seven Lee
2020-04-24 11:27 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-29 9:00 Seven Lee
2020-04-29 16:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424112722.GE5850@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=wtli@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox