From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 517A8C433E0 for ; Wed, 1 Jul 2020 15:05:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC5220760 for ; Wed, 1 Jul 2020 15:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="NkwsVwPx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0d5o1da3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC5220760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 69B0F1679; Wed, 1 Jul 2020 17:04:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 69B0F1679 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1593615916; bh=hjhEj1kmt32ON01AiaQ46U1TlOLLBrgSiID3pKEF4Ww=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NkwsVwPxmp2NOSOV9EnaJvwrrwrwsaouDMW9nHgO3+b631r7imqwRpkNDOsR0d7zB XM0skAid37oo5ZyO+Ay0t0kVK4tM736baYx9zQhv2rnYvf4yS1J+/89DbLPF3YAKYe 4Rb7E3qsDeO4JL8ORvnqv23ZKjQbzdpqvAwz3JE0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EE4F7F800EA; Wed, 1 Jul 2020 17:04:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C0ABF80217; Wed, 1 Jul 2020 17:04:24 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AEDE8F801D8 for ; Wed, 1 Jul 2020 17:04:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AEDE8F801D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0d5o1da3" Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C42420702; Wed, 1 Jul 2020 15:04:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593615856; bh=hjhEj1kmt32ON01AiaQ46U1TlOLLBrgSiID3pKEF4Ww=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0d5o1da3fLwEiMclM/eWi3jgM7r4JKqDohkZXx+8IBbCn5CoDZhw/VYem/vlOxWzR Q5z6bLbTTb1h4nKrjEff2GI5zs/zuzsqDe1Ak1P27ebiCBhnasykBTdv+hhWIiJZUa 6Om3t8BS2MQQoyi8YUufZF6UAIzhhrRBh8QRqZLA= Date: Wed, 1 Jul 2020 20:34:12 +0530 From: Vinod Koul To: Charles Keepax Subject: Re: [PATCH v5 3/3] ALSA: compress: fix partial_drain completion state Message-ID: <20200701150412.GC2599@vkoul-mobl> References: <20200629134737.105993-1-vkoul@kernel.org> <20200629134737.105993-4-vkoul@kernel.org> <20200701142032.GG71940@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701142032.GG71940@ediswmail.ad.cirrus.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Srinivas Kandagatla , Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 01-07-20, 14:20, Charles Keepax wrote: > On Mon, Jun 29, 2020 at 07:17:37PM +0530, Vinod Koul wrote: > > On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING > > state, so set that for partially draining streams in > > snd_compr_drain_notify() and use a flag for partially draining streams > > > > While at it, add locks for stream state change in > > snd_compr_drain_notify() as well. > > > > Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)") > > Reviewed-by: Srinivas Kandagatla > > Tested-by: Srinivas Kandagatla > > Signed-off-by: Vinod Koul > > --- > > Worth noting I haven't actually tested the gapless, but keeps all > the compressed capture stuff happy. Thanks for testing and review Charles. Btw Srini is adding support to fcplay so that we can do gapless testing without using HALs/players. Now that we have an public board (RB3) where compress works out of box, we should build more things on top :) -- ~Vinod