From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 2/7] ASoC: codecs: cs42l42: remove always-true comparisons
Date: Wed, 1 Jul 2020 13:13:15 -0500 [thread overview]
Message-ID: <20200701181320.80848-3-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20200701181320.80848-1-pierre-louis.bossart@linux.intel.com>
Fix W=1 warnings:
cs42l42.c: In function 'cs42l42_handle_device_data':
cs42l42.c:1661:12: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
1661 | if ((val >= CS42L42_BTN_DET_INIT_DBNCE_MIN) &&
| ^~
cs42l42.c:1679:12: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
1679 | if ((val >= CS42L42_BTN_DET_EVENT_DBNCE_MIN) &&
| ^~
cs42l42.c:1698:23: warning: comparison of unsigned expression >= 0 is
always true [-Wtype-limits]
1698 | if ((thresholds[i] >= CS42L42_HS_DET_LEVEL_MIN) &&
| ^~
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/codecs/cs42l42.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c
index 3bc2fa229ef3..d391b5074904 100644
--- a/sound/soc/codecs/cs42l42.c
+++ b/sound/soc/codecs/cs42l42.c
@@ -1658,8 +1658,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
ret = of_property_read_u32(np, "cirrus,btn-det-init-dbnce", &val);
if (!ret) {
- if ((val >= CS42L42_BTN_DET_INIT_DBNCE_MIN) &&
- (val <= CS42L42_BTN_DET_INIT_DBNCE_MAX))
+ if (val <= CS42L42_BTN_DET_INIT_DBNCE_MAX)
cs42l42->btn_det_init_dbnce = val;
else {
dev_err(&i2c_client->dev,
@@ -1676,8 +1675,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
ret = of_property_read_u32(np, "cirrus,btn-det-event-dbnce", &val);
if (!ret) {
- if ((val >= CS42L42_BTN_DET_EVENT_DBNCE_MIN) &&
- (val <= CS42L42_BTN_DET_EVENT_DBNCE_MAX))
+ if (val <= CS42L42_BTN_DET_EVENT_DBNCE_MAX)
cs42l42->btn_det_event_dbnce = val;
else {
dev_err(&i2c_client->dev,
@@ -1695,8 +1693,7 @@ static int cs42l42_handle_device_data(struct i2c_client *i2c_client,
if (!ret) {
for (i = 0; i < CS42L42_NUM_BIASES; i++) {
- if ((thresholds[i] >= CS42L42_HS_DET_LEVEL_MIN) &&
- (thresholds[i] <= CS42L42_HS_DET_LEVEL_MAX))
+ if (thresholds[i] <= CS42L42_HS_DET_LEVEL_MAX)
cs42l42->bias_thresholds[i] = thresholds[i];
else {
dev_err(&i2c_client->dev,
--
2.25.1
next prev parent reply other threads:[~2020-07-01 18:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:13 [PATCH 0/7] ASoC: codecs: wm/cs: fix kernel-doc and W=1 warnings Pierre-Louis Bossart
2020-07-01 18:13 ` [PATCH 1/7] ASoC: codecs: cs4270: fix kernel-doc Pierre-Louis Bossart
2020-07-01 18:13 ` Pierre-Louis Bossart [this message]
2020-07-01 18:13 ` [PATCH 3/7] ASoC: codecs: wm8986: fix missing kernel-doc arguments Pierre-Louis Bossart
2020-07-02 9:17 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 4/7] ASoC: codecs: wm8960: fix kernel-doc Pierre-Louis Bossart
2020-07-02 9:18 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 5/7] ASoC: codecs: wm9713: remove spurious kernel-doc comment start Pierre-Louis Bossart
2020-07-02 9:18 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 6/7] ASoC: codecs: wm8994: fix kernel-doc Pierre-Louis Bossart
2020-07-02 9:19 ` Charles Keepax
2020-07-01 18:13 ` [PATCH 7/7] ASoC: codecs: wm8400: add _maybe_unused as needed Pierre-Louis Bossart
2020-07-02 9:23 ` Charles Keepax
2020-07-02 15:07 ` Pierre-Louis Bossart
2020-07-02 15:46 ` [PATCH 0/7] ASoC: codecs: wm/cs: fix kernel-doc and W=1 warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701181320.80848-3-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox