Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Poirier <benjamin.poirier@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Kailang Yang <kailang@realtek.com>, Takashi Iwai <tiwai@suse.com>,
	Hui Wang <hui.wang@canonical.com>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Vincent Bernat <vincent@bernat.ch>,
	Even Brenden <evenbrenden@gmail.com>,
	Mark Pearson <mpearson@lenovo.com>
Subject: Re: [External] Re: [PATCH v2 2/2] ALSA: hda/realtek - Replace Lenovo Thinkpad X1 Carbon 7th quirk
Date: Mon, 6 Jul 2020 08:31:19 +0900	[thread overview]
Message-ID: <20200705233119.GB2439@f3> (raw)
In-Reply-To: <a09194c3-3f2e-823c-e455-b7c5e7d73e28@perex.cz>

On 2020-07-03 14:43 +0200, Jaroslav Kysela wrote:
> Dne 03. 07. 20 v 12:59 Mark Pearson napsal(a):
> > 
> > > -----Original Message-----
> > > From: Alsa-devel <alsa-devel-bounces@alsa-project.org> On Behalf Of
> > > Jaroslav Kysela
> > > Sent: Friday, July 3, 2020 6:34 AM
> > > 
> > > Dne 03. 07. 20 v 10:00 Benjamin Poirier napsal(a):
> > > > As a result of commit d2cd795c4ece ("ALSA: hda - fixup for the bass
> > > > speaker on Lenovo Carbon X1 7th gen"), the sound output level on my machine, an
> > > > X1 Carbon 7th gen, was reduced to ~65% of its previous level when playing
> > > > certain sounds. [1]
> > > > 
> > <snip>
> > > 
> > > Thank you for this work. Perhaps, Takashi will have some comments to
> > > improve this quirk.
> > Seconded - thank you!
> > 
> > <snip>
> > > 
> > > > It is possible that the X1 Carbon 8th gen would benefit from the same
> > > > changes but I don't have a device to test that. Fixups are reordered so
> > > > that the devices for 7th & 8th gen can share the same chain after the first
> > > > fixup. The resulting chain is:
> > > 
> > > 8th gen hardware should be similar, so the new fixup should be applied to this
> > > hw, too.
> > > 
> > We'll do some testing here and confirm the fixes on the X1C7 and X1C8 (and Yoga)
> > 
> > Do let me know if there is any details Lenovo can provide that would help
> 
> The functionality of this patch is same like the hda-verb command is
> executed with the current kernel (run as root):
> 
> hda-verb /dev/snd/hwC0D0 0x17 SET_CONNECT_SEL 1
> 
> You can control tweeters with 'Speaker' volume control.
> And headphones and bass speakers with the 'Headphone' volume control.

For other X1 users who might stumble upon this discussion; practical
usage of the hda-verb trick requires a way to apply it automatically[1]
and changes to the ucm profile[2].

[1] https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3345062
[2] https://gist.github.com/hamidzr/dd81e429dc86f4327ded7a2030e7d7d9#gistcomment-3335517

I've added more information here:
https://github.com/gobenji/thinkpad-x1-gen7-sound/tree/c5ebc9166e955934dab03d6c4fb5928cf28496b0#alternative-2---runtime-reconfiguration

  reply	other threads:[~2020-07-05 23:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03  8:00 [PATCH v2 0/2] Fix Lenovo ThinkPad X1 Carbon 7th gen bass volume Benjamin Poirier
2020-07-03  8:00 ` [PATCH v2 1/2] ALSA: hda/realtek - Fix Lenovo Thinkpad X1 Carbon 7th quirk subdevice id Benjamin Poirier
2020-07-07  8:16   ` Takashi Iwai
2020-07-03  8:00 ` [PATCH v2 2/2] ALSA: hda/realtek - Replace Lenovo Thinkpad X1 Carbon 7th quirk Benjamin Poirier
2020-07-03 10:33   ` Jaroslav Kysela
2020-07-03 10:59     ` [External] " Mark Pearson
2020-07-03 12:43       ` Jaroslav Kysela
2020-07-05 23:31         ` Benjamin Poirier [this message]
2020-07-05 23:19     ` Benjamin Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200705233119.GB2439@f3 \
    --to=benjamin.poirier@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=evenbrenden@gmail.com \
    --cc=hui.wang@canonical.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kailang@realtek.com \
    --cc=mpearson@lenovo.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=vincent@bernat.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox