From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] ALSA: atmel: Remove invalid "fall through" comments
Date: Thu, 9 Jul 2020 11:33:26 -0500 [thread overview]
Message-ID: <20200709163326.GC15020@embeddedor> (raw)
In-Reply-To: <20200709111750.8337-2-tiwai@suse.de>
On Thu, Jul 09, 2020 at 01:17:48PM +0200, Takashi Iwai wrote:
> The comments about fall through in sound/atmel/ac97.c are just
> superfluous and rather confusing. Let's remove them.
>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> sound/atmel/ac97c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a62f1cdad68f..1006458f7f85 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -219,7 +219,7 @@ static int atmel_ac97c_playback_prepare(struct snd_pcm_substream *substream)
> switch (runtime->format) {
> case SNDRV_PCM_FORMAT_S16_LE:
> break;
> - case SNDRV_PCM_FORMAT_S16_BE: /* fall through */
> + case SNDRV_PCM_FORMAT_S16_BE:
> word &= ~(AC97C_CMR_CEM_LITTLE);
> break;
> default:
> @@ -301,7 +301,7 @@ static int atmel_ac97c_capture_prepare(struct snd_pcm_substream *substream)
> switch (runtime->format) {
> case SNDRV_PCM_FORMAT_S16_LE:
> break;
> - case SNDRV_PCM_FORMAT_S16_BE: /* fall through */
> + case SNDRV_PCM_FORMAT_S16_BE:
> word &= ~(AC97C_CMR_CEM_LITTLE);
> break;
> default:
> --
> 2.16.4
>
next prev parent reply other threads:[~2020-07-09 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 11:17 [PATCH 0/3] ALSA: Convert remaining fall through comments Takashi Iwai
2020-07-09 11:17 ` [PATCH 1/3] ALSA: atmel: Remove invalid "fall through" comments Takashi Iwai
2020-07-09 16:33 ` Gustavo A. R. Silva [this message]
2020-07-09 11:17 ` [PATCH 2/3] ALSA: xen: Remove superfluous fall through comments Takashi Iwai
2020-07-09 16:33 ` Gustavo A. R. Silva
2020-07-09 11:17 ` [PATCH 3/3] ALSA: Replace with fallthrough pseudo keyword in the remaining places Takashi Iwai
2020-07-09 16:32 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709163326.GC15020@embeddedor \
--to=gustavoars@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox