From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8ADFC433DF for ; Tue, 21 Jul 2020 02:13:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C03E2072E for ; Tue, 21 Jul 2020 02:13:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="naiLKcoq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C03E2072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 93E8041; Tue, 21 Jul 2020 04:12:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 93E8041 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1595297599; bh=Wd+RJDtjybh53jqcmXzlsw+Ln4yJuFKK9ho7SBzI5Ys=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=naiLKcoqfvBH+bZMKM+WTrWpgOf5zW2lemYeW0anjiNRwMDCdeJpjszQjUg6mcGwD p9mjnqBMM9zDMTJnKyH87EAqq7RbCGUG0oUw+4GvfgYKTCFtvywgAv5rMi+36z5ZrK Z+FR68b3m3DIk3GHlvGQo66HFdx9TPSXwzUM8C7M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2EA61F80212; Tue, 21 Jul 2020 04:12:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3EB01F8024A; Tue, 21 Jul 2020 04:12:27 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 19C0DF800CE for ; Tue, 21 Jul 2020 04:12:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 19C0DF800CE Received: by mail-il1-f193.google.com with SMTP id s21so15058960ilk.5 for ; Mon, 20 Jul 2020 19:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NQUTeffJMHXMiqbsPX2xwEkXM3c5RyktUmybjJ1stHs=; b=FMyvaC2a0TJz5qGdLbF4dFwwhsnF2jlPskO7VLdDB4Mfvx2adgCRH4hB9GctDVsTN5 OmvLOJvdS14TSxjh4m+750Hj5NJzM/FbYgdDkg/pZCam4iLdwaPaATf7fBxFg7iY1Byc FFp5TyM4PXq35obAolbx46Jb6q3hV86KlilY0Bg5+PPRFiZiexrdk1VMUo81gIRqYUav mD8KIMQ8O5xWMfi5Lz436qENFLjQjuEJoXPmvd0UkBF6ABB1EIgAn7PNOMITHr0obua8 UCMRvtrFXf4q2JdCHTLPsXn/R0SLy2CH+FJHnUFdrb0Jdlw1NxpIOKNnpoEwWaatI790 iBMQ== X-Gm-Message-State: AOAM533mi3UCtQLv/Uc42Mqd1nMaUn/P26OP5Ew/P83WRwkbu9I+FHHk fCdHJ9J7HFaMS9R8Mg5jSA== X-Google-Smtp-Source: ABdhPJzJnKhYPFFl4Fz41JdJz6qoRM9fJhj/Uf8pUDziQOo+75dmr6QMoYBHE/FV+bE8f94gH1De6g== X-Received: by 2002:a92:a312:: with SMTP id a18mr18402751ili.308.1595297532855; Mon, 20 Jul 2020 19:12:12 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id s5sm4527756ioo.29.2020.07.20.19.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 19:12:12 -0700 (PDT) Received: (nullmailer pid 3389433 invoked by uid 1000); Tue, 21 Jul 2020 02:12:11 -0000 Date: Mon, 20 Jul 2020 20:12:11 -0600 From: Rob Herring To: Katsuhiro Suzuki Subject: Re: [PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml Message-ID: <20200721021211.GA3388250@bogus> References: <20200714081000.177914-1-katsuhiro@katsuster.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714081000.177914-1-katsuhiro@katsuster.net> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jul 14, 2020 at 05:09:59PM +0900, Katsuhiro Suzuki wrote: > This patch converts ROHM BD28623UMV class D speaker amplifier binding > to DT schema. > > Signed-off-by: Katsuhiro Suzuki > --- > .../bindings/sound/rohm,bd28623.txt | 29 --------- > .../bindings/sound/rohm,bd28623.yaml | 65 +++++++++++++++++++ > 2 files changed, 65 insertions(+), 29 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.txt > create mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.yaml > > diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt > deleted file mode 100644 > index d84557c2686e..000000000000 > --- a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt > +++ /dev/null > @@ -1,29 +0,0 @@ > -ROHM BD28623MUV Class D speaker amplifier for digital input > - > -This codec does not have any control buses such as I2C, it detect format and > -rate of I2S signal automatically. It has two signals that can be connected > -to GPIOs: reset and mute. > - > -Required properties: > -- compatible : should be "rohm,bd28623" > -- #sound-dai-cells: should be 0. > -- VCCA-supply : regulator phandle for the VCCA supply > -- VCCP1-supply : regulator phandle for the VCCP1 supply > -- VCCP2-supply : regulator phandle for the VCCP2 supply > - > -Optional properties: > -- reset-gpios : GPIO specifier for the active low reset line > -- mute-gpios : GPIO specifier for the active low mute line > - > -Example: > - > - codec { > - compatible = "rohm,bd28623"; > - #sound-dai-cells = <0>; > - > - VCCA-supply = <&vcc_reg>; > - VCCP1-supply = <&vcc_reg>; > - VCCP2-supply = <&vcc_reg>; > - reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>; > - mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; > - }; > diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml > new file mode 100644 > index 000000000000..acd8609252b4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/rohm,bd28623.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BD28623MUV Class D speaker amplifier for digital input > + > +description: > + This codec does not have any control buses such as I2C, it detect > + format and rate of I2S signal automatically. It has two signals > + that can be connected to GPIOs reset and mute. > + > +maintainers: > + - Katsuhiro Suzuki > + > +properties: > + compatible: > + const: rohm,bd28623 > + > + "#sound-dai-cells": > + const: 0 > + > + VCCA-supply: > + description: > + regulator phandle for the VCCA (for analog) power supply > + > + VCCP1-supply: > + description: > + regulator phandle for the VCCP1 (for ch1) power supply > + > + VCCP2-supply: > + description: > + regulator phandle for the VCCP2 (for ch2) power supply > + > + reset-gpios: > + maxItems: 1 > + description: > + GPIO specifier for the active low reset line > + > + mute-gpios: > + maxItems: 1 > + description: > + GPIO specifier for the active low mute line > + > +required: > + - compatible > + - VCCA-supply > + - VCCP1-supply > + - VCCP2-supply > + - "#sound-dai-cells" Needs an: additionalProperties: false With that, Reviewed-by: Rob Herring > + > +examples: > + - | > + #include > + codec { > + compatible = "rohm,bd28623"; > + #sound-dai-cells = <0>; > + > + VCCA-supply = <&vcc_reg>; > + VCCP1-supply = <&vcc_reg>; > + VCCP2-supply = <&vcc_reg>; > + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>; > + mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; > + }; > -- > 2.27.0 >