public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: "René Herman" <rene.herman@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Torsten Schenk <torsten.schenk@zoho.com>
Subject: [PATCH v2 0/2] snd-usb-6fire: firmware load and pulseaudio assumption
Date: Tue, 21 Jul 2020 11:57:46 +0200	[thread overview]
Message-ID: <20200721095748.16224-1-rene.herman@gmail.com> (raw)

Hi Takashi.

v2 of the earlier today sent out "set" for snd-usb-6fire, although now
only two patches left, incorportaing the requested changes.

The snd-usb-6fire driver for the TerraTec DMX 6Fire USB soundcard has
been failing its firmware upload due to a non DMA-capable buffer on the
stack. First of the patches kmallocs said bufffer instead and fixes the
firmware upload; also makes it more alsa-generic by using the "goto out"
structure. Note that it only looks a bit ungeneric as a patch due to
also needing to at the same time unify its failure path: it's obvious
when looked at post-apply.

After that first patch the driver nominally works again but still has
Pulseaudio crap out due to struct snd_pcm_hardware.channels_min=1
causing it to recognize it as a mono device only. Comparing with e.g.
the TerraTec Aureon 7.1 Universe driver it seems that the solution is to
simply set channels_min=2 as per the second patch.

With these changes the card works again. Driver author Torsten Schenk
has seen these and is fine with them: maintains an external driver with
more options. I or he might time permitting start integrating more into
the kernel driver over time.

Regards,
René

René Herman (2):
  Move DMA-buffer off the stack
  Pulseaudio needs snd_pcm_hardware.channels_min > 1

 sound/usb/6fire/firmware.c | 95 ++++++++++++++++++--------------------
 sound/usb/6fire/pcm.c      |  2 +-
 2 files changed, 47 insertions(+), 50 deletions(-)

-- 
2.17.1


             reply	other threads:[~2020-07-21 10:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  9:57 René Herman [this message]
2020-07-21  9:57 ` [PATCH v2 1/2] Move DMA-buffer off the stack René Herman
2020-07-21 10:03   ` Takashi Iwai
2020-07-21 10:09     ` René Herman
2020-07-21  9:57 ` [PATCH v2 2/2] Pulseaudio needs snd_pcm_hardware.channels_min > 1 René Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721095748.16224-1-rene.herman@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    --cc=torsten.schenk@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox