From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC6DC433E2 for ; Sat, 29 Aug 2020 11:01:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41EA2207DF for ; Sat, 29 Aug 2020 11:01:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pofPAgzD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bJnOvrmE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41EA2207DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CEDF418DA; Sat, 29 Aug 2020 13:01:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CEDF418DA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598698910; bh=WGE/Ni8OgdnjEaI12x6E3/36gjTN5CWhg+VbB/qhaqE=; h=Date:From:To:Subject:In-Reply-To:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=pofPAgzDFFmBfQMvSUh3IIRa2P6UISL2AiPm2NArbEpH95RJNEBwxfuCCja/GvU65 rZPUwbLqpp/Oj9uZWTcWpAUzmQVUKSEv6RgGfojtGaIyLHSQ7hLgP8/M2xOM/yA/hg jawOiyI9zV7J9zocWdBpybRwc+XU/qQkTS0COQoo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 459DEF80245; Sat, 29 Aug 2020 13:01:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AE000F8025A; Sat, 29 Aug 2020 13:00:58 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B9102F8012E for ; Sat, 29 Aug 2020 13:00:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B9102F8012E Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bJnOvrmE" Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 581F4207DF; Sat, 29 Aug 2020 11:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598698851; bh=WGE/Ni8OgdnjEaI12x6E3/36gjTN5CWhg+VbB/qhaqE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bJnOvrmEP3qQTbfhE1/jw5kbaTMAOYtleMdzUUT9cIxQMOjn8Lq4dVhAkOnXeTBe6 O8LO8m0Bx55WrC11vqnNdsdNgnHwCGsUBTLE326hyT/40/2POv3i/v3US8LT0hMYH/ SKGboRGHLqFc9fsyw21UAySMuQUwNNecQzpVHVVs= Date: Sat, 29 Aug 2020 16:30:47 +0530 From: Vinod Koul To: Bard Liao , Pierre-Louis Bossart Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs Message-ID: <20200829110047.GC2639@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818024120.20721-10-yung-chuan.liao@linux.intel.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, mengdong.lin@intel.com, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 28-08-20, 09:54, Pierre-Louis Bossart wrote: > > > > > > Detect cases where the clock is assumed to be stopped but the IP is > > > > > not in the relevant state, and add a dynamic debug trace. > > > > > > > > you meant a debug print..and it looks like error print below (also in title). > > > > > > I don't understand the comment. Is the 'trace' confusing and are you asking > > > to e.g. change the commit message to 'add dynamic debug log'? > > > > Question is what is dynamic about this? > dev_dbg() is part of the kernel dynamic debug capability... > > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html > > Not sure what you are asking here? :-| where is dev_dbg() ? See [1] On 18-08-20, 10:41, Bard Liao wrote: > From: Pierre-Louis Bossart > > Detect cases where the clock is assumed to be stopped but the IP is > not in the relevant state, and add a dynamic debug trace. > > Signed-off-by: Pierre-Louis Bossart > Signed-off-by: Bard Liao > --- > drivers/soundwire/intel.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index 7c63581270fd..b82d02af3c4f 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1964,6 +1964,11 @@ static int intel_resume_runtime(struct device *dev) > } > } > } else if (!clock_stop_quirks) { > + > + clock_stop0 = sdw_cdns_is_clock_stop(&sdw->cdns); > + if (!clock_stop0) [1] > + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); ^^^^^^^ > + > ret = intel_init(sdw); > if (ret) { > dev_err(dev, "%s failed: %d", __func__, ret); > -- > 2.17.1 -- ~Vinod