From: Alan Stern <stern@rowland.harvard.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: alsa-devel@alsa-project.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, marcel@holtmann.org,
linux-usb@vger.kernel.org, tiwai@suse.com,
stern@rowland.harvard.ed, linux-bluetooth@vger.kernel.org,
dvyukov@google.com, himadrispandya@gmail.com
Subject: Re: [PATCH 04/10] USB: core: hub.c: use usb_control_msg_send() in a few places
Date: Wed, 2 Sep 2020 10:57:01 -0400 [thread overview]
Message-ID: <20200902145701.GA624583@rowland.harvard.edu> (raw)
In-Reply-To: <20200902110115.1994491-5-gregkh@linuxfoundation.org>
On Wed, Sep 02, 2020 at 01:01:06PM +0200, Greg Kroah-Hartman wrote:
> There are a few calls to usb_control_msg() that can be converted to use
> usb_control_msg_send() instead, so do that in order to make the error
> checking a bit simpler and the code smaller.
>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
One problem in this patch...
> @@ -3896,27 +3875,14 @@ static int usb_req_set_sel(struct usb_device *udev, enum usb3_link_state state)
> if (u2_pel > USB3_LPM_MAX_U2_SEL_PEL)
> u2_pel = USB3_LPM_MAX_U2_SEL_PEL;
>
> - /*
> - * usb_enable_lpm() can be called as part of a failed device reset,
> - * which may be initiated by an error path of a mass storage driver.
> - * Therefore, use GFP_NOIO.
> - */
> - sel_values = kmalloc(sizeof *(sel_values), GFP_NOIO);
> - if (!sel_values)
> - return -ENOMEM;
> -
> - sel_values->u1_sel = u1_sel;
> - sel_values->u1_pel = u1_pel;
> - sel_values->u2_sel = cpu_to_le16(u2_sel);
> - sel_values->u2_pel = cpu_to_le16(u2_pel);
> + sel_values.u1_sel = u1_sel;
> + sel_values.u1_pel = u1_pel;
> + sel_values.u2_sel = cpu_to_le16(u2_sel);
> + sel_values.u2_pel = cpu_to_le16(u2_pel);
>
> - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
> - USB_REQ_SET_SEL,
> - USB_RECIP_DEVICE,
> - 0, 0,
> - sel_values, sizeof *(sel_values),
> - USB_CTRL_SET_TIMEOUT);
> - kfree(sel_values);
> + ret = usb_control_msg_send(udev, 0, USB_REQ_SET_SEL, USB_RECIP_DEVICE,
> + 0, 0, &sel_values, sizeof(sel_values),
> + USB_CTRL_SET_TIMEOUT);
This effectively changes GFP_NOIO to GFP_KERNEL. Probably you should
leave this particular call alone.
Alan Stern
next prev parent reply other threads:[~2020-09-02 14:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 11:01 [PATCH 00/10] USB: new USB control message helper functions Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 01/10] USB: move snd_usb_pipe_sanity_check into the USB core Greg Kroah-Hartman
2020-09-02 14:35 ` Takashi Iwai
2020-09-07 14:42 ` Greg Kroah-Hartman
2020-09-03 0:45 ` Alan Stern
2020-09-03 6:40 ` Takashi Iwai
2020-09-03 7:32 ` Greg Kroah-Hartman
2020-09-07 14:16 ` Greg Kroah-Hartman
2020-09-07 14:24 ` Alan Stern
2020-09-02 11:01 ` [PATCH 02/10] USB: add usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 03/10] USB: core: message.c: use usb_control_msg_send() in a few places Greg Kroah-Hartman
2020-09-02 11:23 ` Andy Shevchenko
2020-09-02 11:01 ` [PATCH 04/10] USB: core: hub.c: " Greg Kroah-Hartman
2020-09-02 14:57 ` Alan Stern [this message]
2020-09-02 15:21 ` Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 05/10] USB: legousbtower: use usb_control_msg_recv() Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 06/10] sound: usx2y: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-02 14:36 ` Takashi Iwai
2020-09-02 11:01 ` [PATCH 07/10] sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-02 14:36 ` Takashi Iwai
2020-09-02 11:01 ` [PATCH 7/9] sound: line6: convert to use new usb control function Greg Kroah-Hartman
2020-09-02 14:41 ` Takashi Iwai
2020-09-02 15:22 ` Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 8/9] sound: 6fire: move to use new usb control functions Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 08/10] sound: line6: move to use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-02 14:38 ` Takashi Iwai
2020-09-02 11:01 ` [PATCH 9/9] sound: hiface: convert to use new usb_control functions Greg Kroah-Hartman
2020-09-02 11:01 ` [PATCH 09/10] sound: hiface: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-02 14:40 ` Takashi Iwai
2020-09-02 11:01 ` [PATCH 10/10] Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902145701.GA624583@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=alsa-devel@alsa-project.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=himadrispandya@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stern@rowland.harvard.ed \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).