From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D750EC433E2 for ; Mon, 7 Sep 2020 14:25:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A291C20768 for ; Mon, 7 Sep 2020 14:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GTXiMQp6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A291C20768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3A08B177C; Mon, 7 Sep 2020 16:24:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3A08B177C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1599488729; bh=Iy1rGrYuMCu7YBQhcazfqubnSv1MpoGyCHM1NgTDQmo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GTXiMQp6Qx70SHtY6RFF98/v52lTK194QwPCjVCQg/obXp5idEDk3wPriSnzCEgX5 s3eCCFp6vwOq6IlyPnZV0fxAHPqf0OrFH5dVO8XiG5pSByePYX2BrLk4UVCMfu3Mak AEXOo3G6dBdyN2DHl7gzHWU+RermAmA88qpT6DrI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 412B4F8021C; Mon, 7 Sep 2020 16:24:38 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56982F80227; Mon, 7 Sep 2020 16:24:37 +0200 (CEST) Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by alsa1.perex.cz (Postfix) with SMTP id ED249F800D3 for ; Mon, 7 Sep 2020 16:24:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ED249F800D3 Received: (qmail 762519 invoked by uid 1000); 7 Sep 2020 10:24:27 -0400 Date: Mon, 7 Sep 2020 10:24:27 -0400 From: Alan Stern To: Greg Kroah-Hartman Subject: Re: [PATCH 01/10] USB: move snd_usb_pipe_sanity_check into the USB core Message-ID: <20200907142427.GB762136@rowland.harvard.edu> References: <20200902110115.1994491-1-gregkh@linuxfoundation.org> <20200902110115.1994491-2-gregkh@linuxfoundation.org> <20200903004553.GA642955@rowland.harvard.edu> <20200903073230.GA162335@kroah.com> <20200907141634.GA3733019@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200907141634.GA3733019@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, "Gustavo A. R. Silva" , Jesus Ramos , johan.hedberg@gmail.com, Chris Wulff , Nick Kossifidis , marcel@holtmann.org, linux-usb@vger.kernel.org, Dmitry Panchenko , linux-kernel@vger.kernel.org, Jussi Laako , linux-bluetooth@vger.kernel.org, Eli Billauer , Emiliano Ingrassia , Alexander Tsoy , tiwai@suse.com, "Geoffrey D. Bennett" , dvyukov@google.com, himadrispandya@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 07, 2020 at 04:16:34PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 03, 2020 at 09:32:30AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Sep 02, 2020 at 08:45:53PM -0400, Alan Stern wrote: > > > Since this routine is used in only one place in the entire kernel, you > > > might as well inline the code there and get rid of the function > > > entirely. > > > > Good idea, will do. > > No, wait, the USB sound drivers call it a lot, so it needs to stick > around for now until we clean that up. Argh. I must have run "git grep" from within drivers/usb/core. My mistake. Alan Stern