From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: himadrispandya@gmail.com, dvyukov@google.com, linux-usb@vger.kernel.org
Cc: alsa-devel@alsa-project.org, johan.hedberg@gmail.com,
Takashi Iwai <tiwai@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
marcel@holtmann.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, stern@rowland.harvard.ed,
linux-bluetooth@vger.kernel.org
Subject: [PATCH v2 09/11] sound: hiface: move to use usb_control_msg_send()
Date: Mon, 7 Sep 2020 16:51:06 +0200 [thread overview]
Message-ID: <20200907145108.3766613-10-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <20200907145108.3766613-1-gregkh@linuxfoundation.org>
The usb_control_msg_send() call can return an error if a "short" write
happens, so move the driver over to using that call instead.
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2:
- Added reviewed-by from Takashi
sound/usb/hiface/pcm.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/sound/usb/hiface/pcm.c b/sound/usb/hiface/pcm.c
index a148caa5f48e..f9c924e3964e 100644
--- a/sound/usb/hiface/pcm.c
+++ b/sound/usb/hiface/pcm.c
@@ -156,16 +156,14 @@ static int hiface_pcm_set_rate(struct pcm_runtime *rt, unsigned int rate)
* This control message doesn't have any ack from the
* other side
*/
- ret = usb_control_msg(device, usb_sndctrlpipe(device, 0),
- HIFACE_SET_RATE_REQUEST,
- USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
- rate_value, 0, NULL, 0, 100);
- if (ret < 0) {
+ ret = usb_control_msg_send(device, 0,
+ HIFACE_SET_RATE_REQUEST,
+ USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_OTHER,
+ rate_value, 0, NULL, 0, 100);
+ if (ret)
dev_err(&device->dev, "Error setting samplerate %d.\n", rate);
- return ret;
- }
- return 0;
+ return ret;
}
static struct pcm_substream *hiface_pcm_get_substream(struct snd_pcm_substream
--
2.28.0
next prev parent reply other threads:[~2020-09-07 14:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 14:50 [PATCH v2 00/11] USB: new USB control message helper functions Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 01/11] USB: move snd_usb_pipe_sanity_check into the USB core Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 02/11] USB: add usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 03/11] USB: core: message.c: use usb_control_msg_send() in a few places Greg Kroah-Hartman
2020-09-07 14:56 ` Greg Kroah-Hartman
2020-09-07 15:48 ` Andy Shevchenko
2020-09-07 14:51 ` [PATCH v2 04/11] USB: core: hub.c: " Greg Kroah-Hartman
2020-09-07 15:08 ` Alan Stern
2020-09-14 15:23 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 05/11] USB: legousbtower: use usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 06/11] sound: usx2y: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 07/11] sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 08/11] sound: line6: " Greg Kroah-Hartman
2020-09-07 14:51 ` Greg Kroah-Hartman [this message]
2020-09-07 14:51 ` [PATCH v2 10/11] Bluetooth: ath3k: " Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 11/11] ALSA: remove calls to usb_pipe_type_check for control endpoints Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907145108.3766613-10-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=dvyukov@google.com \
--cc=himadrispandya@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stern@rowland.harvard.ed \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).