From: Alan Stern <stern@rowland.harvard.edu>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: alsa-devel@alsa-project.org, johan.hedberg@gmail.com,
linux-kernel@vger.kernel.org, marcel@holtmann.org,
linux-usb@vger.kernel.org, tiwai@suse.com,
stern@rowland.harvard.ed, linux-bluetooth@vger.kernel.org,
dvyukov@google.com, himadrispandya@gmail.com
Subject: Re: [PATCH v2 04/11] USB: core: hub.c: use usb_control_msg_send() in a few places
Date: Mon, 7 Sep 2020 11:08:58 -0400 [thread overview]
Message-ID: <20200907150858.GD762136@rowland.harvard.edu> (raw)
In-Reply-To: <20200907145108.3766613-5-gregkh@linuxfoundation.org>
On Mon, Sep 07, 2020 at 04:51:01PM +0200, Greg Kroah-Hartman wrote:
> There are a few calls to usb_control_msg() that can be converted to use
> usb_control_msg_send() instead, so do that in order to make the error
> checking a bit simpler and the code smaller.
>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2:
> - dropped changes to usb_req_set_sel() thanks to review from Alan
> @@ -4056,7 +4035,7 @@ static void usb_enable_link_state(struct usb_hcd *hcd, struct usb_device *udev,
> * associated with the link state we're about to enable.
> */
> ret = usb_req_set_sel(udev, state);
> - if (ret < 0) {
> + if (ret) {
> dev_warn(&udev->dev, "Set SEL for device-initiated %s failed.\n",
> usb3_lpm_names[state]);
> return;
Did this change survive by mistake?
Actually, it looks like usb_req_set_sel needs to check the value
returned by usb_control_msg -- a perfect example of the sort of thing
you were trying to fix in the first place!
Alan Stern
next prev parent reply other threads:[~2020-09-07 15:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 14:50 [PATCH v2 00/11] USB: new USB control message helper functions Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 01/11] USB: move snd_usb_pipe_sanity_check into the USB core Greg Kroah-Hartman
2020-09-07 14:50 ` [PATCH v2 02/11] USB: add usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 03/11] USB: core: message.c: use usb_control_msg_send() in a few places Greg Kroah-Hartman
2020-09-07 14:56 ` Greg Kroah-Hartman
2020-09-07 15:48 ` Andy Shevchenko
2020-09-07 14:51 ` [PATCH v2 04/11] USB: core: hub.c: " Greg Kroah-Hartman
2020-09-07 15:08 ` Alan Stern [this message]
2020-09-14 15:23 ` Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 05/11] USB: legousbtower: use usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 06/11] sound: usx2y: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 07/11] sound: 6fire: move to use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 08/11] sound: line6: " Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 09/11] sound: hiface: move to use usb_control_msg_send() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 10/11] Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() Greg Kroah-Hartman
2020-09-07 14:51 ` [PATCH v2 11/11] ALSA: remove calls to usb_pipe_type_check for control endpoints Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907150858.GD762136@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=alsa-devel@alsa-project.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=himadrispandya@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=stern@rowland.harvard.ed \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).