From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 231E9C433E2 for ; Wed, 16 Sep 2020 09:07:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A9D42087D for ; Wed, 16 Sep 2020 09:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="dw+wbDL0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bsWQuzvW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A9D42087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AEEF1827; Wed, 16 Sep 2020 11:06:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AEEF1827 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600247256; bh=Dfwbci88DTkyCRzDTgwvZH7qGaycD4hKjVm1q2R6nDI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dw+wbDL0U7GJbEqVURTJKBl6AcSCCS2GBG+M3jTy6NIyIWBO+CRm3FeoawFgjJpv5 Lj9G1XqIKCrDoRAAyUDcUUY0/ubIptqglGDabY+/RRUr7k+Y8k7T+S099YRWbA1zLI ETLcQw/O4RtxazFHPqtxiqJLSHuNrY3DBJ9E0+g0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 189A1F800E8; Wed, 16 Sep 2020 11:06:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C624F8015A; Wed, 16 Sep 2020 11:06:44 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D47E3F800E8 for ; Wed, 16 Sep 2020 11:06:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D47E3F800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bsWQuzvW" Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B20F921974; Wed, 16 Sep 2020 09:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600247190; bh=Dfwbci88DTkyCRzDTgwvZH7qGaycD4hKjVm1q2R6nDI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bsWQuzvWoVSuUq700Adg7BMCU+7Pad8dakDZORQGKVPwk48j/EqXdFnRrGzLT44TS oWbbT033KjoAt97oXXS1a6qmCQwJ9WUqELN0czuU7AO8AfvZBv/JXdcnYCjj9M+5kf GQRn/mLUWDrHjqL9HyfVntGTUcmgZZMahsKZZ84w= Date: Wed, 16 Sep 2020 11:06:41 +0200 From: Greg Kroah-Hartman To: Alan Stern Subject: Re: [PATCH v3 04/11] USB: core: hub.c: use usb_control_msg_send() in a few places Message-ID: <20200916090641.GA710715@kroah.com> References: <20200914153756.3412156-1-gregkh@linuxfoundation.org> <20200914153756.3412156-5-gregkh@linuxfoundation.org> <20200914180616.GB972479@rowland.harvard.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914180616.GB972479@rowland.harvard.edu> Cc: alsa-devel@alsa-project.org, johan.hedberg@gmail.com, linux-kernel@vger.kernel.org, marcel@holtmann.org, linux-usb@vger.kernel.org, tiwai@suse.com, stern@rowland.harvard.ed, linux-bluetooth@vger.kernel.org, dvyukov@google.com, himadrispandya@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 14, 2020 at 02:06:16PM -0400, Alan Stern wrote: > On Mon, Sep 14, 2020 at 05:37:49PM +0200, Greg Kroah-Hartman wrote: > > There are a few calls to usb_control_msg() that can be converted to use > > usb_control_msg_send() instead, so do that in order to make the error > > checking a bit simpler and the code smaller. > > > > Cc: Alan Stern > > Signed-off-by: Greg Kroah-Hartman > > --- > > v3: > > - drop change in usb_enable_link_state() as it was not needed now > > thanks to review from Alan > > - minor changes requested by checkpatch.pl > > > > v2: > > - dropped changes to usb_req_set_sel() thanks to review from Alan > > > > drivers/usb/core/hub.c | 99 +++++++++++++++++------------------------- > > 1 file changed, 40 insertions(+), 59 deletions(-) > > Reviewed-by: Alan Stern Thanks for the review! greg k-h