From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] soundwire: qcom: clear BIT FIELDs before value set.
Date: Wed, 16 Sep 2020 19:59:29 +0530 [thread overview]
Message-ID: <20200916142929.GR2968@vkoul-mobl> (raw)
In-Reply-To: <24401c7c-b12c-0924-9d8f-fde633d15918@linux.intel.com>
On 16-09-20, 08:18, Pierre-Louis Bossart wrote:
>
> > > According to usage (bitfields.h) of REG_FIELDS,
> > > Modify is:
> > > reg &= ~REG_FIELD_C;
> > > reg |= FIELD_PREP(REG_FIELD_C, c);
>
>
> if this is indeed the case, all the code in cadence_master.c is also broken,
> e.g:
>
> dpn_config = cdns_readl(cdns, dpn_config_off);
>
> dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_WL, (p_params->bps - 1));
> dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_PORT_FLOW, p_params->flow_mode);
> dpn_config |= FIELD_PREP(CDNS_DPN_CONFIG_PORT_DAT, p_params->data_mode);
This should be replaced with u32_replace_bits(), i am sending the fix
>
>
> Gah.
should have caught this :(
--
~Vinod
next prev parent reply other threads:[~2020-09-16 14:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 9:21 [PATCH v2 0/3] soundwire: qcom: fix IP version v1.5.1 support Srinivas Kandagatla
2020-09-16 9:21 ` [PATCH v2 1/3] soundwire: qcom: clear BIT FIELDs before value set Srinivas Kandagatla
2020-09-16 12:46 ` Vinod Koul
2020-09-16 13:18 ` Pierre-Louis Bossart
2020-09-16 14:29 ` Vinod Koul [this message]
2020-09-16 14:36 ` Pierre-Louis Bossart
2020-09-16 14:48 ` Vinod Koul
2020-09-16 9:21 ` [PATCH v2 2/3] soundwire: qcom: add support to block packing mode Srinivas Kandagatla
2020-09-16 9:21 ` [PATCH v2 3/3] soundwire: qcom: get max rows and cols info from compatible Srinivas Kandagatla
2020-09-16 12:49 ` Vinod Koul
2020-09-16 12:54 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916142929.GR2968@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox