From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04482C4363D for ; Tue, 22 Sep 2020 14:26:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC5520C09 for ; Tue, 22 Sep 2020 14:26:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="GF4xOg4v"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="b+zh2DI3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC5520C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DFD6816C8; Tue, 22 Sep 2020 16:25:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DFD6816C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600784778; bh=BjcEs/cyjGNFH4+Iv6NV3gAcUsMvzMLKmIq/2ekfuaQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GF4xOg4vi3Ulvgo6FCC9KftS2tkzJe2/O1XNdehI9D5JqqGnZEdjaY/rA5synqnqx 9y1s7ph7Cpavmm3Hzl5JOESwCMntonnp4G+XdJZBOTSo1enW+01O/fHcsIHbrDy1xp ei6vu1dgHZLkgwqp8PtynFztaCmiJUxchygeI/VI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80980F80234; Tue, 22 Sep 2020 16:25:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD50DF8023E; Tue, 22 Sep 2020 16:25:25 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 22775F80229 for ; Tue, 22 Sep 2020 16:25:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 22775F80229 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="b+zh2DI3" Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4659220C09; Tue, 22 Sep 2020 14:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600784716; bh=BjcEs/cyjGNFH4+Iv6NV3gAcUsMvzMLKmIq/2ekfuaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+zh2DI3qvzE0CrDPaxWv1J4MDNlht5urMzZMCMsvYshQYFJf+FQXsNH27lu4xRcB f3cuz90yMYI+GgorDpgyxeX5rvT478Fr5iw2La3MMmh253JrUav8jT6zDe5gU1jQMV aU3Ffy4uZW/7goLBmKO7llVuQZEKM9l17TLr9pJY= Date: Tue, 22 Sep 2020 10:25:15 -0400 From: Sasha Levin To: Mark Brown Subject: Re: [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811 Message-ID: <20200922142515.GN2431@sasha-vm> References: <20200921144027.2135390-1-sashal@kernel.org> <20200921144027.2135390-3-sashal@kernel.org> <20200921150701.GA12231@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200921150701.GA12231@sirena.org.uk> Cc: alsa-devel@alsa-project.org, Charles Keepax , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Sep 21, 2020 at 04:07:01PM +0100, Mark Brown wrote: >On Mon, Sep 21, 2020 at 10:40:10AM -0400, Sasha Levin wrote: > >> The WM8994_MICBIAS register is not available in the WM1811 CODEC so skip >> initialization of that register for that device. >> This suppresses an error during boot: >> "wm8994-codec: ASoC: error at snd_soc_component_update_bits on wm8994-codec" > >This is pretty much a cosmetic change - previously we were silently not >reading the register, this just removes the attempt to read it since we >added an error message in the core. Right, the only reason I took it is that error message - I find that bogus error messages have almost the same (bad) impact as real kernel bugs. I can drop it if you'd prefer. -- Thanks, Sasha