From: Sasha Levin <sashal@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Charles Keepax <ckeepax@opensource.cirrus.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811
Date: Tue, 22 Sep 2020 13:46:47 -0400 [thread overview]
Message-ID: <20200922174647.GP2431@sasha-vm> (raw)
In-Reply-To: <20200922144221.GW4792@sirena.org.uk>
On Tue, Sep 22, 2020 at 03:42:21PM +0100, Mark Brown wrote:
>On Tue, Sep 22, 2020 at 10:25:15AM -0400, Sasha Levin wrote:
>> On Mon, Sep 21, 2020 at 04:07:01PM +0100, Mark Brown wrote:
>
>> > This is pretty much a cosmetic change - previously we were silently not
>> > reading the register, this just removes the attempt to read it since we
>> > added an error message in the core.
>
>> Right, the only reason I took it is that error message - I find that
>> bogus error messages have almost the same (bad) impact as real kernel
>> bugs.
>
>The point is that the error message isn't present in stable kernels so
>there is no impact on any user visible behaviour.
Ah, I see. I'll drop it. Thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2020-09-22 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200921144027.2135390-1-sashal@kernel.org>
2020-09-21 14:40 ` [PATCH AUTOSEL 5.8 02/20] ASoC: pcm3168a: ignore 0 Hz settings Sasha Levin
2020-09-21 14:40 ` [PATCH AUTOSEL 5.8 03/20] ASoC: wm8994: Skip setting of the WM8994_MICBIAS register for WM1811 Sasha Levin
2020-09-21 15:07 ` Mark Brown
2020-09-22 14:25 ` Sasha Levin
2020-09-22 14:42 ` Mark Brown
2020-09-22 17:46 ` Sasha Levin [this message]
2020-09-21 14:40 ` [PATCH AUTOSEL 5.8 04/20] ASoC: wm8994: Ensure the device is resumed in wm89xx_mic_detect functions Sasha Levin
2020-09-21 14:40 ` [PATCH AUTOSEL 5.8 05/20] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1 Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922174647.GP2431@sasha-vm \
--to=sashal@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).