From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: alsa-devel@alsa-project.org,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
"Clemens Ladisch" <clemens@ladisch.de>,
kernel-janitors@vger.kernel.org, "Takashi Iwai" <tiwai@suse.com>,
"Joe Perches" <joe@perches.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] ALSA: fireworks: use semicolons rather than commas to separate statements
Date: Sun, 11 Oct 2020 20:32:47 +0900 [thread overview]
Message-ID: <20201011113247.GA333010@workstation> (raw)
In-Reply-To: <1602407979-29038-5-git-send-email-Julia.Lawall@inria.fr>
Hi,
On Sun, Oct 11, 2020 at 11:19:35AM +0200, Julia Lawall wrote:
> Replace commas with semicolons. What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
>
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> sound/firewire/fireworks/fireworks_pcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/fireworks/fireworks_pcm.c b/sound/firewire/fireworks/fireworks_pcm.c
> index 980580dfbb39..a0d5db1d8eb2 100644
> --- a/sound/firewire/fireworks/fireworks_pcm.c
> +++ b/sound/firewire/fireworks/fireworks_pcm.c
> @@ -148,7 +148,7 @@ pcm_init_hw_params(struct snd_efw *efw,
> }
>
> /* limit rates */
> - runtime->hw.rates = efw->supported_sampling_rate,
> + runtime->hw.rates = efw->supported_sampling_rate;
> snd_pcm_limit_hw_rates(runtime);
>
> limit_channels(&runtime->hw, pcm_channels);
Oops. It seems to be my typo added at the commit aa02bb6e6078
("ALSA: fireworks: Add PCM interface")...
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Thanks
Takashi Sakamoto
next prev parent reply other threads:[~2020-10-11 11:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-11 9:19 [PATCH 0/8] use semicolons rather than commas to separate statements Julia Lawall
2020-10-11 9:19 ` [PATCH 1/8] ASoC: wm8350: " Julia Lawall
2020-10-12 9:26 ` Charles Keepax
2020-10-11 9:19 ` [PATCH 2/8] ALSA: hda: " Julia Lawall
2020-10-12 6:52 ` Takashi Iwai
2020-10-11 9:19 ` [PATCH 3/8] ASoC: Intel: bytcr_rt5651: " Julia Lawall
2020-10-12 7:14 ` Rojewski, Cezary
2020-10-11 9:19 ` [PATCH 4/8] ALSA: fireworks: " Julia Lawall
2020-10-11 11:32 ` Takashi Sakamoto [this message]
2020-10-12 6:53 ` Takashi Iwai
2020-10-11 9:19 ` [PATCH 5/8] ASoC: SOF: Intel: hda: " Julia Lawall
2020-10-11 9:19 ` [PATCH 6/8] ASoC: samsung: snow: " Julia Lawall
2020-10-12 7:12 ` Krzysztof Kozlowski
2020-10-11 9:19 ` [PATCH 7/8] ASoC: madera: " Julia Lawall
2020-10-12 9:26 ` Charles Keepax
2020-10-11 9:19 ` [PATCH 8/8] ASoC: dapm: " Julia Lawall
2020-10-26 23:45 ` [PATCH 0/8] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011113247.GA333010@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=Julia.Lawall@inria.fr \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).