From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E402C2D0A3 for ; Fri, 6 Nov 2020 08:47:20 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3232B20936 for ; Fri, 6 Nov 2020 08:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vkIrVq/y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3232B20936 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4C09B1695; Fri, 6 Nov 2020 09:46:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4C09B1695 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1604652437; bh=OhObnJUaGdEshEB1bQEN9zZtB/TMwsY0esFitMXBrvc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=vkIrVq/yZJLlhp7Jz+nvXjQ9uA7eZd3zzUlo6M7Ou+xBttNKTyXvtAa9KnowtLF+F ELqGQWqi8gV5yjD+m+PHfnNyr9e+4U5Cno3flU3zvHVGVT0qnXFHvIwBO7fjzjOFdp EUNdr+BrXg11WpimQnbmZWQEy+naIVE+cXeedPS4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 6621CF804E4; Fri, 6 Nov 2020 09:43:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 180E3F80171; Thu, 5 Nov 2020 20:35:25 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 94DD6F800BA for ; Thu, 5 Nov 2020 20:35:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 94DD6F800BA Received: from localhost (searspoint.nvidia.com [216.228.112.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C91620728; Thu, 5 Nov 2020 19:35:14 +0000 (UTC) Date: Thu, 5 Nov 2020 21:35:11 +0200 From: Leon Romanovsky To: "Ertman, David M" Subject: Re: [PATCH v3 01/10] Add auxiliary bus support Message-ID: <20201105193511.GB5475@unreal> References: <20201023003338.1285642-1-david.m.ertman@intel.com> <20201023003338.1285642-2-david.m.ertman@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Fri, 06 Nov 2020 09:43:15 +0100 Cc: "alsa-devel@alsa-project.org" , Parav Pandit , Takashi Iwai , Netdev , Ranjani Sridharan , Pierre-Louis Bossart , Fred Oh , linux-rdma , Doug Ledford , Mark Brown , Jason Gunthorpe , Greg KH , Jakub Kicinski , "Williams, Dan J" , "Saleem, Shiraz" , David Miller , Linux Kernel Mailing List , "Patil, Kiran" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Nov 05, 2020 at 07:27:56PM +0000, Ertman, David M wrote: > > -----Original Message----- > > From: Dan Williams > > Sent: Thursday, November 5, 2020 1:19 AM > > To: Ertman, David M > > Cc: alsa-devel@alsa-project.org; Takashi Iwai ; Mark Brown > > ; linux-rdma ; Jason > > Gunthorpe ; Doug Ledford ; > > Netdev ; David Miller ; > > Jakub Kicinski ; Greg KH ; > > Ranjani Sridharan ; Pierre-Louis Bossart > > ; Fred Oh ; > > Parav Pandit ; Saleem, Shiraz > > ; Patil, Kiran ; Linux > > Kernel Mailing List ; Leon Romanovsky > > > > Subject: Re: [PATCH v3 01/10] Add auxiliary bus support > > > > Some doc fixups, and minor code feedback. Otherwise looks good to me. > > > > On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman > > wrote: <...> > > Again, thanks for the review Dan. Changes will be in next release (v4) once I give > stake-holders a little time to respond. Everything here can go as a Fixes, the review comments are valuable and need to be fixed, but they don't change anything dramatically that prevent from merging v3. Thanks > > -DaveE