From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3438C56202 for ; Thu, 26 Nov 2020 04:27:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4683121741 for ; Thu, 26 Nov 2020 04:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="WgSLa+RN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLtI8KH5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4683121741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7407317C4; Thu, 26 Nov 2020 05:27:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7407317C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1606364874; bh=9Ab23uvA6gXoRUJ95dH3UVCAG+CifoKA/aDKNyM0a8A=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WgSLa+RNPcXy3w8wjy6BgAeSHFlnpME6BagM6sr8uFDjWwG99uzBy3a+DMgPBtbRn 8kY2RcDMJwgqrZE+Od7flyYtJ+ut4bEbU/P2Z2xcwkdpr8YP4PpzrlEqfLkaiZ36b9 R+OjXjT2ExXROQGb0bYw8F5gNgmwBtVhC/GemD1A= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D25A4F80164; Thu, 26 Nov 2020 05:27:03 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E305AF80165; Thu, 26 Nov 2020 05:27:02 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D88E7F80128 for ; Thu, 26 Nov 2020 05:26:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D88E7F80128 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLtI8KH5" Received: from localhost (unknown [122.179.79.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C51521741; Thu, 26 Nov 2020 04:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606364811; bh=9Ab23uvA6gXoRUJ95dH3UVCAG+CifoKA/aDKNyM0a8A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fLtI8KH5wUOVTxE+nyeGSuezEqsK9cAE8jeOLXlbIz2kEvhFGmE/9CSTPV059Kh9E vJB0YPH/jG+5eOGo8oa6nwmq+pkzRp13wRnULW4s46O7X0NKgIBWUdsJ5osuvf4Ekt FWEaez9fYQuTMifCzBS7flTgh7GbkYad1jMg4bys= Date: Thu, 26 Nov 2020 09:56:46 +0530 From: Vinod Koul To: Randy Dunlap Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus' Message-ID: <20201126042646.GH8403@vkoul-mobl> References: <202011030351.iq9CBMO3-lkp@intel.com> <20201125055155.GD8403@vkoul-mobl> <6e298ed8-dc23-7a1f-1bb1-44ba2f43ee07@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e298ed8-dc23-7a1f-1bb1-44ba2f43ee07@infradead.org> Cc: Pierre-Louis Bossart , moderated for non-subscribers , kbuild-all@lists.01.org, kernel test robot , Jonathan Marek , linux-kernel@vger.kernel.org, Bjorn Andersson , Srinivas Kandagatla , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 25-11-20, 09:31, Randy Dunlap wrote: > On 11/24/20 9:51 PM, Vinod Koul wrote: > > From: Vinod Koul > > Date: Wed, 25 Nov 2020 11:15:22 +0530 > > Subject: [PATCH] soundwire: qcom: Fix build failure when slimbus is module > > > > Commit 5bd773242f75 ("soundwire: qcom: avoid dependency on > > CONFIG_SLIMBUS") removed hard dependency on Slimbus for qcom driver but > > it results in build failure when: > > CONFIG_SOUNDWIRE_QCOM=y > > CONFIG_SLIMBUS=m > > > > drivers/soundwire/qcom.o: In function `qcom_swrm_probe': > > qcom.c:(.text+0xf44): undefined reference to `slimbus_bus' > > > > Fix this by using IS_REACHABLE() in driver which is recommended to be > > sued with imply. > > used right > > > > > Fixes: 5bd773242f75 ("soundwire: qcom: avoid dependency on CONFIG_SLIMBUS") > > Reported-by: kernel test robot > > Signed-off-by: Vinod Koul > > Acked-by: Randy Dunlap # build-tested Thanks I have added this and Srini's and pushed out now. -- ~Vinod