From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
alsa-devel@alsa-project.org,
Akshu Agrawal <akshu.agrawal@amd.com>
Subject: [PATCH 1/2] ASoC: amd: Downgrade print level for invalid ACP mode
Date: Fri, 27 Nov 2020 15:31:58 +0100 [thread overview]
Message-ID: <20201127143200.16272-2-tiwai@suse.de> (raw)
In-Reply-To: <20201127143200.16272-1-tiwai@suse.de>
The acp3x raven driver skips the probing when the given device isn't
connected with I2S. This skip behavior itself is fine, but the driver
also emits an error message "Invalid ACP audio mode" with KERN_ERR.
This isn't nice since it appears on the boot screen even if a boot
splash is running, although this itself is no real error.
Downgrade the print level to KERN_INFO so that this message won't
appear on the console unnecessarily.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210359
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/soc/amd/raven/pci-acp3x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index 31b797c8bfe6..a7de4e607961 100644
--- a/sound/soc/amd/raven/pci-acp3x.c
+++ b/sound/soc/amd/raven/pci-acp3x.c
@@ -231,7 +231,7 @@ static int snd_acp3x_probe(struct pci_dev *pci,
}
break;
default:
- dev_err(&pci->dev, "Invalid ACP audio mode : %d\n", val);
+ dev_info(&pci->dev, "Invalid ACP audio mode : %d\n", val);
ret = -ENODEV;
goto disable_msi;
}
--
2.26.2
next prev parent reply other threads:[~2020-11-27 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 14:31 [PATCH 0/2] ASoC: amd: Minor fixes for error handling Takashi Iwai
2020-11-27 14:31 ` Takashi Iwai [this message]
2020-11-27 14:31 ` [PATCH 2/2] ASoC: amd: Return -ENODEV for non-existing ACPI call Takashi Iwai
2020-11-30 16:55 ` [PATCH 0/2] ASoC: amd: Minor fixes for error handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127143200.16272-2-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=akshu.agrawal@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).