alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>, alsa-devel@alsa-project.org
Subject: [RFC SOF 2/2] topology: Add sof-cht-nau8824 topology file
Date: Sun,  6 Dec 2020 13:46:26 +0100	[thread overview]
Message-ID: <20201206124626.13932-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20201206124626.13932-1-hdegoede@redhat.com>

This uses the new sof-byt-codec-tdm4.m4 file, as the cht_bsw_nau8824
machine driver programs the link to TDM 4 slots 24 bit.

At first I thought it would be easier to just change the kernel to
use the standard I2S 2 channel 24 bit format as other codecs do,
but this causes problems with the right speaker/headphone channel
unless the chan mixer-control for this is changed from CH1 to CH0,
which requires UCM changes, so changing this at the kernel level will
break setups with older UCM files (and updating UCM will break older
kernels).

So we are stuck with the TDM 4 slots 24 bit format for these boards,
as we cannot change it without causing regressions.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 tools/topology/CMakeLists.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/topology/CMakeLists.txt b/tools/topology/CMakeLists.txt
index 57f908302..72f1c6ef4 100644
--- a/tools/topology/CMakeLists.txt
+++ b/tools/topology/CMakeLists.txt
@@ -63,6 +63,7 @@ set(TPLGS
 	"sof-byt-codec\;sof-cht-da7213\;-DCODEC=DA7213\;-DPLATFORM=cht-codec\;-DSSP_NUM=2"
 	"sof-byt-codec\;sof-cht-cx2072x\;-DCODEC=CX2072X\;-DPLATFORM=cht-codec\;-DSSP_NUM=2"
 	"sof-byt-codec\;sof-cht-es8316\;-DCODEC=ES8316\;-DPLATFORM=cht-codec\;-DSSP_NUM=2"
+	"sof-byt-codec-tdm4\;sof-cht-nau8824\;-DCODEC=NAU8824\;-DPLATFORM=cht-codec\;-DSSP_NUM=2"
 	"sof-cht-max98090\;sof-cht-max98090\;-DCODEC=MAX98090\;-DPLATFORM=cht-codec\;-DSSP_NUM=2"
 	"sof-cnl-rt274\;sof-cnl-rt274"
 	"sof-apl-tdf8532\;sof-apl-tdf8532"
-- 
2.28.0


      parent reply	other threads:[~2020-12-06 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 12:46 [RFC SOF 0/2] topology: Try to add sof-cht-nau8824 topology file Hans de Goede
2020-12-06 12:46 ` [RFC SOF 1/2] topology: Add sof-byt-codec-tdm4.m4 file Hans de Goede
2020-12-07 15:11   ` Pierre-Louis Bossart
2020-12-07 15:17     ` Hans de Goede
2020-12-06 12:46 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206124626.13932-3-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).