From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFA7C433DB for ; Thu, 7 Jan 2021 16:42:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31ACA23403 for ; Thu, 7 Jan 2021 16:42:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31ACA23403 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 624DC168D; Thu, 7 Jan 2021 17:41:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 624DC168D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610037724; bh=fOWMAya6MUgIxPCi2rUu0Qt+PUSCQkj1fFqZohufbqw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Jl66abHR2pJwjpUNXhXerPZcY7EfDVraNL9t7KB26fn94w16CaT+/idrFKXdJioIO rM3vXqROEs5JKA5RTYtuWr6dZa30Kk8NNAQAAHfAvVaKnJ5VB3w7D+s+dpMDqzgvV4 /GSAGFZtr98588oxvl2cpnCmjlmqPG4KgIxmmJLU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CB667F801F5; Thu, 7 Jan 2021 17:41:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0AEE4F80258; Thu, 7 Jan 2021 17:41:12 +0100 (CET) Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by alsa1.perex.cz (Postfix) with ESMTP id 809FEF800FD for ; Thu, 7 Jan 2021 17:41:04 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 809FEF800FD Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kxYL4-0000Tv-00; Thu, 07 Jan 2021 17:40:42 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 98E5BC080E; Thu, 7 Jan 2021 17:40:15 +0100 (CET) Date: Thu, 7 Jan 2021 17:40:15 +0100 From: Thomas Bogendoerfer To: Joe Perches Subject: Re: [PATCH 05/10] dma: tx49 removal Message-ID: <20210107164015.GA12533@alpha.franken.de> References: <20210105140305.141401-1-tsbogend@alpha.franken.de> <20210105140305.141401-6-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Alexandre Belloni , Vignesh Raghavendra , Liam Girdwood , alsa-devel@alsa-project.org, Takashi Iwai , linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Miquel Raynal , linux-spi@vger.kernel.org, linux-rtc@vger.kernel.org, Wim Van Sebroeck , Herbert Xu , Richard Weinberger , Jakub Kicinski , Guenter Roeck , linux-watchdog@vger.kernel.org, Mark Brown , Matt Mackall , Dan Williams , Alessandro Zummo , netdev@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, "David S. Miller" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jan 06, 2021 at 11:10:38AM -0800, Joe Perches wrote: > On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > > Signed-off-by: Thomas Bogendoerfer > [] > > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h > [] > > @@ -26,11 +26,6 @@ > >   * DMA channel. > >   */ > >   > > > > -#ifdef CONFIG_MACH_TX49XX > > -static inline bool txx9_dma_have_SMPCHN(void) > > -{ > > - return true; > > -} > >  #define TXX9_DMA_USE_SIMPLE_CHAIN > >  #else > >  static inline bool txx9_dma_have_SMPCHN(void) > > This doesn't look like it compiles as there's now an #else > without an #if you are right, no idea what I had in mind while doing that. Vinod, as this patch series found a still active user of the platform, could you drop the patch from your tree, or do you want a revert from me ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]