From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack()
Date: Thu, 7 Jan 2021 12:42:22 -0800 [thread overview]
Message-ID: <20210107204222.GA11567@Asurada-Nvidia> (raw)
In-Reply-To: <20210107165131.2535-1-stephan@gerhold.net>
On Thu, Jan 07, 2021 at 05:51:31PM +0100, Stephan Gerhold wrote:
> Sound is broken on the DragonBoard 410c (apq8016_sbc) since 5.10:
>
> hdmi-audio-codec hdmi-audio-codec.1.auto: ASoC: error at snd_soc_component_set_jack on hdmi-audio-codec.1.auto: -95
> qcom-apq8016-sbc 7702000.sound: Failed to set jack: -95
> ADV7533: ASoC: error at snd_soc_link_init on ADV7533: -95
> hdmi-audio-codec hdmi-audio-codec.1.auto: ASoC: error at snd_soc_component_set_jack on hdmi-audio-codec.1.auto: -95
> qcom-apq8016-sbc: probe of 7702000.sound failed with error -95
>
> This happens because apq8016_sbc calls snd_soc_component_set_jack() on
> all codec DAIs and attempts to ignore failures with return code -ENOTSUPP.
> -ENOTSUPP is also excluded from error logging in soc_component_ret().
>
> However, hdmi_codec_set_jack() returns -E*OP*NOTSUPP if jack detection
> is not supported, which is not handled in apq8016_sbc and soc_component_ret().
> Make it return -ENOTSUPP instead to fix sound and silence the errors.
>
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> Fixes: 55c5cc63ab32 ("ASoC: hdmi-codec: Use set_jack ops to set jack")
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
For imx-hdmi:
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
next prev parent reply other threads:[~2021-01-07 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 16:51 [PATCH v2] ASoC: hdmi-codec: Fix return value in hdmi_codec_set_jack() Stephan Gerhold
2021-01-07 20:42 ` Nicolin Chen [this message]
2021-01-08 16:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210107204222.GA11567@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=shengjiu.wang@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=stephan@gerhold.net \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox