From: Mark Brown <broonie@kernel.org>
To: Curtis Malainey <cujomalainey@google.com>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Takashi Iwai" <tiwai@suse.de>, "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Derek [方德義]" <derek.fang@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Curtis Malainey" <cujomalainey@chromium.org>,
"Bard liao" <yung-chuan.liao@linux.intel.com>,
"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt5682: remove jack detect delay
Date: Mon, 22 Feb 2021 13:45:51 +0000 [thread overview]
Message-ID: <20210222134551.GC6127@sirena.org.uk> (raw)
In-Reply-To: <CAOReqxibmAQNQe8PuHkUSW5Kb2L986X9DDqia-aN=ZrS8VJysA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Thu, Feb 18, 2021 at 01:06:27PM -0800, Curtis Malainey wrote:
> I am trying to understand the purpose of this delay currently, won't
> the press already be registered since we have an interrupt? Or does it need
> to stabilize? The reason is 250ms is well within human perception or even
> double tap time, which results in users possibly double tapping buttons but
> only seeing one press come through.
It's quite common to have lots of issues with debounce on jacks,
especially around insert/removal - it looks like this delay covers both
insert/removal and button presses so it may well be needed for robust
handling of the actual jack insert.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-22 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 21:49 [PATCH] ASoC: rt5682: remove jack detect delay Curtis Malainey
2021-02-17 21:51 ` Curtis Malainey
[not found] ` <5b90530b77744937b87bbbd35901e320@realtek.com>
2021-02-18 8:44 ` Takashi Iwai
2021-02-18 21:06 ` Curtis Malainey
2021-02-22 13:45 ` Mark Brown [this message]
2021-02-22 18:59 ` Curtis Malainey
2021-02-23 12:42 ` Mark Brown
2021-02-23 18:50 ` Curtis Malainey
2021-02-23 19:04 ` Mark Brown
2021-02-23 20:07 ` Curtis Malainey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222134551.GC6127@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cujomalainey@chromium.org \
--cc=cujomalainey@google.com \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox