From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C93C433E0 for ; Tue, 23 Feb 2021 17:23:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59CFF64DE7 for ; Tue, 23 Feb 2021 17:23:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59CFF64DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A53171662; Tue, 23 Feb 2021 18:22:09 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A53171662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614100979; bh=Wjq7Hic2f6/w0DEt68eBWex/bWnDMeF9BQWhdL/aD5Y=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aMI3aKNb8WDwDahhxOa4ywIQA8XYkE/AmCEGYsnUWI+m1HojkkX7YNP4AHbfMQjVN kEYDa81PD29PPDcN+cB2cdvgIePm/agnxrfBdfDtb6tLO4ffjMv7503BDix2zRicvv D4cD9W+hU8PgJBLOkNmNNYupC3OVisuDKDQnue+M= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2A27FF80167; Tue, 23 Feb 2021 18:22:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C123AF80169; Tue, 23 Feb 2021 18:22:07 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D987FF800B4 for ; Tue, 23 Feb 2021 18:21:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D987FF800B4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RaPeRlLl" Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A81C64DE7; Tue, 23 Feb 2021 17:21:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614100917; bh=Wjq7Hic2f6/w0DEt68eBWex/bWnDMeF9BQWhdL/aD5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RaPeRlLlyhn0UKwy50gYuQDYcw3R7UbKP124ASdyjCdcGBFs0xHE/bAjwnQY/80LK zeYziSLucq2odghiodSx5q7iHd6HqXgQ44mw01Pxizx/HUXwU8MF5VyuC0ju1pEadE DjzuBERHUjztyxzPhSk94iQkBF5HJ5D2LPMiPvp7+/bJjnZPgbQ62MvSKIj9p8RkJC gA4lJ/s4zUvhDlH+krlGIfIaap7xNBc/9GrFE+kgkWXBQUYY8aWFCL/0FNILqVMo6L WSQV56tcqhbcF7bVQagSU9wwrt/9udjiqw94FOui/ueDHhsnQsvdJUgEajNUQ53LQg MLS0zWT6pDCsw== Date: Tue, 23 Feb 2021 17:20:55 +0000 From: Mark Brown To: Jaroslav Kysela Subject: Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support Message-ID: <20210223172055.GI5116@sirena.org.uk> References: <20210215142419.308651-1-hdegoede@redhat.com> <20210215142419.308651-3-hdegoede@redhat.com> <20210223134506.GF5116@sirena.org.uk> <578b1ee3-f426-c5b5-bc78-5a91108ebdc8@redhat.com> <20210223140930.GH5116@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HuscSE0D68UGttcd" Content-Disposition: inline In-Reply-To: X-Cookie: Kilroe hic erat! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , alsa-devel@alsa-project.org, Takashi Iwai , Liam Girdwood , Hans de Goede , Bard Liao X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --HuscSE0D68UGttcd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 23, 2021 at 05:14:32PM +0100, Jaroslav Kysela wrote: > Dne 23. 02. 21 v 15:21 Takashi Iwai napsal(a): > > That's one of my concerns in the recent actions for putting the > > hard-coded mute LED controls. So far, the only usage of led-audio > > trigger is HD-audio, and it's enabled only for selected devices and > > setups. OTOH, if we apply the audio-led trigger generically in ASoC > > codec driver, it's always done and might misfit; e.g. what happens if > > two codecs are present on the system?. > That's the abstraction issue. We can use PCI, ACPI, DMI or DT checks at the > _right_ place (machine top-level code) to mark those controls with the LED > flags in the kernel space. I've never said that the right place is the generic > ASoC codec driver. We already need ACPI and DMI quirks in the CODEC drivers anyway due to the limitations of ACPI so it wouldn't be particularly surprising to have stuff there. OTOH this would fix things per machine while with fancier hardware things might easily be flexible enough that there's multiple choices that could be made depending on use case. I'd be a lot more comfortable with ASoC having some runtime control for overriding which controls get mapped, even if we try to pick defaults with quirks. --HuscSE0D68UGttcd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA1OXcACgkQJNaLcl1U h9BJewf+NVadyOATdjxt+ItsaAmZ7G9kd7Pmtt9JPOFDxjjcFrXmtbQbKkD5Roex Eiu0+nVrDrTPvv1pCbbaJkXXbxWIGH93K+/jhDjwcoY1ykQttlPDI7255jU5p9Kg s3zmtLpVAmz/12hfDZdpAFZ6Ii8SFNLAmpzPHbhoqQXzEk7EPQ231vYN+FZhTTVU 0mg6PYtsWPkGXZsLsyXx2m+J8DArkfyvwIyRrErA5uW2aVZ7ePZoWPeUQcEo+HbP LTVQsG9CP40E9AJkdbMJM0siPwMjGH7Bbhd3lq+AbJhk/AwIa1vvyKW8WF9UQARf FPq1oC04hMB0Zci7UXfEJtszfGARxQ== =3d0S -----END PGP SIGNATURE----- --HuscSE0D68UGttcd--