From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D280BC433E0 for ; Tue, 23 Feb 2021 19:06:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0966960231 for ; Tue, 23 Feb 2021 19:06:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0966960231 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F15B41678; Tue, 23 Feb 2021 20:05:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F15B41678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1614107201; bh=YdKDpv5otmfNga4OxvhkU5/c1NPbxlVwlJ2ZLTpjUB8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RRD5OIigk5lAXUZkX9ITEyNkw/bDRF79P8W5ql6rceIwWNotC9pSBQplTVC5EkIiX DuG3DWkv8kOq69/4+Z0RNrsCgmxxf4mWbHpD4h2FnMsYLE4Jt/7UV6GZcaQB9pdn0U HIx9JfF8eYA2RNI6EDN7kOBGD1f4NAwthcsm3IAE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 84631F8016A; Tue, 23 Feb 2021 20:05:50 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DD524F8016A; Tue, 23 Feb 2021 20:05:48 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8F2D6F80129 for ; Tue, 23 Feb 2021 20:05:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8F2D6F80129 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IMLr62LK" Received: by mail.kernel.org (Postfix) with ESMTPSA id 786F864E31; Tue, 23 Feb 2021 19:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614107142; bh=YdKDpv5otmfNga4OxvhkU5/c1NPbxlVwlJ2ZLTpjUB8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IMLr62LKO4GFD5ZcPOMm0T0P8W72kEDd9kZZCvxuT1yaIeTb3SDyw8Eb0d47I7Pk2 OSPKjJP9ShQMU8fkgHf+9VG+m1m7ImWt71/vxichDOTIRxf2fKbacr1s+eKucadvyJ ChgzlH415BCyqno9pELx+2wl/NmxJh6vWxl2JIV8X265koEVKIPWUfFcttEozJXL6x 2IVJFWCXh7phqC0qv22w7a5otxq8ksQgpalkCBz8IitPe2m9iiBQYs1iZ+Vrf2p+mt rRdX6S2aa6jVY78R+nUFqIxBoXsxQoHa+GRjMs0LGQco/7dH/nyvVVEmkIB5KrBzBg ky+DM2COHQxLQ== Date: Tue, 23 Feb 2021 19:04:40 +0000 From: Mark Brown To: Curtis Malainey Subject: Re: [PATCH] ASoC: rt5682: remove jack detect delay Message-ID: <20210223190439.GL5116@sirena.org.uk> References: <20210217214914.700751-1-cujomalainey@chromium.org> <5b90530b77744937b87bbbd35901e320@realtek.com> <20210222134551.GC6127@sirena.org.uk> <20210223124230.GA5116@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bX/mw5riLlTkt+Gv" Content-Disposition: inline In-Reply-To: X-Cookie: Kilroe hic erat! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , Jack Yu , "alsa-devel@alsa-project.org" , Takashi Iwai , Takashi Iwai , Liam Girdwood , Derek =?utf-8?B?W+aWueW+t+e+qV0=?= , Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= , Curtis Malainey , Bard liao , "Flove\(HsinFu\)" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --bX/mw5riLlTkt+Gv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 23, 2021 at 10:50:18AM -0800, Curtis Malainey wrote: > > Are you sure that *zero* debounce is needed for the button presses? > > 250ms does look like a lot of time but zero might be going from one > > extreme to the other. > Fair point, I was looking at some other codecs and why they respond so > quickly, it appears they have no fixed delay and just call schedule > work. That being said, I can easily double tap <100ms. So Ideally i > would like to keep this on the order of ~50ms at most. I am guessing > Realtek will want to keep the 250ms for jack detect still. Those feel like plausible numbers to me assuming there's no hardware debounce. > Would queueing two separate jobs with two different delays be the > simple way to go? Realtek does this sound fine to you? Possibly just queuing the same job with different timeouts? I don't have particularly strong feelings assuming the resulting code make sense. --bX/mw5riLlTkt+Gv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA1UccACgkQJNaLcl1U h9CytwgAg4UYOjRnxPahCdO4psMGJn1niME/ODAEyMZCB4RgqRrm0PbwWty1wbv5 7sc5N+RYdA/awxJsa6vfE1qV5FXVwxIMLm/QRM5YlLQa+tekKUXCdi3qFZ321hVF J/PwaItgNgnMSBGG78g1YlYZsLIzPPmtBihHhOWt0/ZZVF3uSzQVIWBGaNBvTRGf hHoUjYTpXiKekqwvk76wdNTiTZG5c0VNATjWM2TnK1wmc+VLDWkB5i4LYqnPKfHy VtXVPzdjayxm+4yF+aM9qrM1Pw001k7Ub6y0t/NQI1hxB85cDqV0GzSRgQl1KWMW E16Octt1z+COhdDNA4cS1eEqXoZ0uw== =EZ1y -----END PGP SIGNATURE----- --bX/mw5riLlTkt+Gv--