From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: <broonie@kernel.org>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
lgirdwood@gmail.com, james.schulman@cirrus.com,
david.rhodes@cirrus.com
Subject: [PATCH 00/10] Tidy up device ID reading on legacy Cirrus parts
Date: Mon, 10 May 2021 14:13:47 +0100 [thread overview]
Message-ID: <20210510131357.17170-1-ckeepax@opensource.cirrus.com> (raw)
Pierre requested I have a look at some cppcheck warnings in the cs42l42
driver, since it is reassigning the ret variable without ever checking
the result. Looking a bit more broadly this happens in quite a few
legacy Cirrus parts, as they all use the same process to read the ID,
factor out a small helper so they can all share the same code. Whilst
in there fix up a couple of other trivial error path issues as well.
Thanks,
Charles
Charles Keepax (10):
ASoC: cirrus: Add helper function for reading the device ID
ASoC: cs35l32: Minor error paths fixups
ASoC: cs35l33: Minor error paths fixups
ASoC: cs35l34: Minor error paths fixups
ASoC: cs35l35: Minor error paths fixups
ASoC: cs35l35: Correct errata handling
ASoC: cs42l42: Minor error paths fixups
ASoC: cs42l73: Minor error paths fixups
ASoC: cs43130: Minor error paths fixups
ASoC: cs53l30: Minor error paths fixups
sound/soc/codecs/cirrus_legacy.h | 21 +++++++++++++++++++++
sound/soc/codecs/cs35l32.c | 34 ++++++++++++++++++----------------
sound/soc/codecs/cs35l33.c | 15 +++++++++------
sound/soc/codecs/cs35l34.c | 39 ++++++++++++++++++++++-----------------
sound/soc/codecs/cs35l35.c | 21 ++++++++++-----------
sound/soc/codecs/cs35l35.h | 1 +
sound/soc/codecs/cs42l42.c | 18 ++++++++----------
sound/soc/codecs/cs42l73.c | 30 +++++++++++++++++-------------
sound/soc/codecs/cs43130.c | 31 +++++++++++++++++++------------
sound/soc/codecs/cs53l30.c | 22 +++++++++++-----------
10 files changed, 136 insertions(+), 96 deletions(-)
create mode 100644 sound/soc/codecs/cirrus_legacy.h
--
2.11.0
next reply other threads:[~2021-05-10 13:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 13:13 Charles Keepax [this message]
2021-05-10 13:13 ` [PATCH 01/10] ASoC: cirrus: Add helper function for reading the device ID Charles Keepax
2021-05-10 13:13 ` [PATCH 02/10] ASoC: cs35l32: Minor error paths fixups Charles Keepax
2021-05-10 13:13 ` [PATCH 03/10] ASoC: cs35l33: " Charles Keepax
2021-05-10 13:13 ` [PATCH 04/10] ASoC: cs35l34: " Charles Keepax
2021-05-10 13:13 ` [PATCH 05/10] ASoC: cs35l35: " Charles Keepax
2021-05-10 13:13 ` [PATCH 06/10] ASoC: cs35l35: Correct errata handling Charles Keepax
2021-05-10 13:13 ` [PATCH 07/10] ASoC: cs42l42: Minor error paths fixups Charles Keepax
2021-05-10 13:13 ` [PATCH 08/10] ASoC: cs42l73: " Charles Keepax
2021-05-10 13:13 ` [PATCH 09/10] ASoC: cs43130: " Charles Keepax
2021-05-10 13:13 ` [PATCH 10/10] ASoC: cs53l30: " Charles Keepax
2021-05-10 14:59 ` [PATCH 00/10] Tidy up device ID reading on legacy Cirrus parts Pierre-Louis Bossart
2021-05-11 9:12 ` Charles Keepax
2021-05-11 8:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510131357.17170-1-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).