From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DE2C4707A for ; Sun, 23 May 2021 09:04:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C37776128A for ; Sun, 23 May 2021 09:04:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C37776128A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 86C561663; Sun, 23 May 2021 11:03:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 86C561663 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621760677; bh=j3WPODAFqyi8LrgqZPViTbAy3ezRdqr3hhR6BS2r9Uc=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XZxoqsGqwGFVYoyMJ5MPTsoGYwRJOJCtf9af9jHO9vEqbMtzgLglAhfUW08XnF17j vjakpCUtg0RWhKeRDTvdk1RDbJRy8nZj3oXzA7iepxDjee45TDXzfllmQXevlVz7zM lMgiTz1oYCb/fDpyKve+tGQjn5sIGL0uRnE8DIig= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 014CAF8019D; Sun, 23 May 2021 11:03:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D9538F801EB; Sun, 23 May 2021 11:03:45 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EB451F8016D for ; Sun, 23 May 2021 11:03:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EB451F8016D Received: by m.b4.vu (Postfix, from userid 1000) id AC316612FB20; Sun, 23 May 2021 18:33:26 +0930 (ACST) Date: Sun, 23 May 2021 18:33:26 +0930 From: "Geoffrey D. Bennett" To: Takashi Iwai Subject: Re: [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static Message-ID: <20210523090326.GA121080@m.b4.vu> References: <202105230212.9rlkrDHb-lkp@intel.com> <20210522180900.GA83915@f59a3af2f1d9> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210522180900.GA83915@f59a3af2f1d9> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Takashi, This patch seems legitimate to me (although I would adjust whitespace so the second line doesn't go over 80 chars). Do you want to just apply it as-is, or do you want me to send a second version of my patch without this problem or send a new patch similar to this one? Also sorry I don't know what the etiquette is in cc's for this message :(. The message from kernel test robot was sent to a lot of people who I don't think would be interested in this, so I trimmed the cc list down. Thanks, Geoffrey. On Sun, May 23, 2021 at 02:09:00AM +0800, kernel test robot wrote: > sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? > > Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages") > Reported-by: kernel test robot > Signed-off-by: kernel test robot > --- > mixer_scarlett_gen2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > index 3ad8f61a2095f..4caf379d5b991 100644 > --- a/sound/usb/mixer_scarlett_gen2.c > +++ b/sound/usb/mixer_scarlett_gen2.c > @@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer) > return usb_submit_urb(mixer->urb, GFP_KERNEL); > } > > -int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, > - const struct scarlett2_device_info *info) > +static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer, > + const struct scarlett2_device_info *info) > { > int err; >