From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC356C47080 for ; Sun, 23 May 2021 09:14:33 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECEA561074 for ; Sun, 23 May 2021 09:14:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECEA561074 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E18B31696; Sun, 23 May 2021 11:13:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E18B31696 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1621761271; bh=RTFSUyfNUzFDBKdN5A9s/WtIAC0evDdWnLeekxDJBzk=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KLbRhovkseBUwysCr29M/8H/UyhaJFVRq9qNeLnMX4FWKkxDdfSW7LJ8dFJ+ST1Bw SYFjystRfAQyjP++0vHcXKsx0NgzA2owbg8EdDQTkn/gZ6Z0vcBH/7m21KyxYLU2Ts ZqmCXE2m1wlntcUOy1KubQjPhzV4xzITg+8RmX5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7DB1DF801F5; Sun, 23 May 2021 11:13:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B2EB5F80212; Sun, 23 May 2021 11:13:39 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ACEB0F80137 for ; Sun, 23 May 2021 11:13:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ACEB0F80137 Received: by m.b4.vu (Postfix, from userid 1000) id 5A693612FB33; Sun, 23 May 2021 18:43:28 +0930 (ACST) Date: Sun, 23 May 2021 18:43:28 +0930 From: "Geoffrey D. Bennett" To: Takashi Iwai Subject: Re: [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static Message-ID: <20210523091328.GA121197@m.b4.vu> References: <202105230212.9rlkrDHb-lkp@intel.com> <20210522180900.GA83915@f59a3af2f1d9> <20210523090326.GA121080@m.b4.vu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sun, May 23, 2021 at 11:10:22AM +0200, Takashi Iwai wrote: > On Sun, 23 May 2021 11:03:26 +0200, > Geoffrey D. Bennett wrote: > > > > Hi Takashi, > > > > This patch seems legitimate to me (although I would adjust whitespace > > so the second line doesn't go over 80 chars). Do you want to just > > apply it as-is, or do you want me to send a second version of my patch > > without this problem or send a new patch similar to this one? > > As it's an obviously correct patch, I already applied as is. Thank you!