From: Mark Brown <broonie@kernel.org>
To: Claudius Heine <ch@denx.de>
Cc: Marek Vasut <marex@denx.de>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
alsa-devel@alsa-project.org,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Sia Jee Heng <jee.heng.sia@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Annaliese McDermond <nh6z@nh6z.net>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants
Date: Tue, 15 Jun 2021 12:54:38 +0100 [thread overview]
Message-ID: <20210615115438.GD5149@sirena.org.uk> (raw)
In-Reply-To: <20210615094933.3076392-2-ch@denx.de>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote:
> With this change it will be possible to add different code paths for
> similar devices.
> static const struct i2c_device_id aic32x4_i2c_id[] = {
> - { "tlv320aic32x4", 0 },
> - { "tlv320aic32x6", 1 },
> + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 },
> + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 },
> { /* sentinel */ }
It appears that the device already supports multiple variants?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-15 11:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:49 [PATCH 0/3] ASoC: tlv320aic32x4: Add support for TAS2505 Claudius Heine
2021-06-15 9:49 ` [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Claudius Heine
2021-06-15 11:54 ` Mark Brown [this message]
2021-06-15 12:06 ` Claudius Heine
2021-06-15 12:30 ` Mark Brown
2021-06-15 9:49 ` [PATCH 2/3] ASoC: tlv320aic32x4: add support for TAS2505 Claudius Heine
2021-06-15 11:59 ` Claudius Heine
2021-06-15 12:22 ` Mark Brown
2021-06-15 12:39 ` Claudius Heine
2021-06-15 9:49 ` [PATCH 3/3] ASoC: tlv320aic32x4: dt-bindings: add TAS2505 to compatible Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615115438.GD5149@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ch@denx.de \
--cc=jee.heng.sia@intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=michael.wei.hong.sit@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=nh6z@nh6z.net \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox