Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: shumingf@realtek.com
Cc: oder_chiou@realtek.com, jack.yu@realtek.com,
	alsa-devel@alsa-project.org, lars@metafoo.de,
	lgirdwood@gmail.com, jairaj.arava@intel.com,
	derek.fang@realtek.com, bard.liao@intel.com,
	sathya.prakash.m.r@intel.com, flove@realtek.com
Subject: Re: [PATCH 1/2] ASoC: rt711: remap buttons
Date: Thu, 17 Jun 2021 13:39:14 +0100	[thread overview]
Message-ID: <20210617123914.GD5067@sirena.org.uk> (raw)
In-Reply-To: <20210617090809.16901-1-shumingf@realtek.com>

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On Thu, Jun 17, 2021 at 05:08:09PM +0800, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> This patch uses the same mapping as the machine driver:
> BTN_0 : KEY_PLAYPAUSE
> BTN_1 : KEY_VOICECOMMAND
> BTN_2 : KEY_VOLUMEUP
> BTN_3 : KEY_VOLUMEDOWN

Which machine driver?  Can't there be multiple machine drivers, and if
they're already overriding things why do this?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-06-17 12:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  9:08 [PATCH 1/2] ASoC: rt711: remap buttons shumingf
2021-06-17 12:39 ` Mark Brown [this message]
     [not found]   ` <d6374c5158c844d69b4f546fd741f07f@realtek.com>
2021-06-17 13:27     ` Mark Brown
2021-06-17 14:23       ` Pierre-Louis Bossart
2021-06-24 18:06         ` Curtis Malainey
2021-06-25 18:31           ` Curtis Malainey
2021-06-30  6:01             ` Shuming [范書銘]
2021-06-30 13:07               ` Mark Brown
2021-06-25  0:56         ` Lu, Brent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617123914.GD5067@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=jairaj.arava@intel.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=sathya.prakash.m.r@intel.com \
    --cc=shumingf@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox