From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01681C07E96 for ; Thu, 15 Jul 2021 06:55:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35E096115B for ; Thu, 15 Jul 2021 06:55:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35E096115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B56961678; Thu, 15 Jul 2021 08:54:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B56961678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626332143; bh=CbrpcyeqpThN22c7AnZ2gvHM/1rSnYyYbfbAjvAEqwU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N/mZw1fnVaFVPawkmIEuwI/WMdvqKUsR/1h2gRNEKPo6JFq7dsavsJJFkIv/mqDg2 wApeLcuSzx7VkyafU3vmqOL4DC30uv0nTM45fnxw/wTneyWdqCN9BR5uJYXP7Rr9Tm Y6ZDCIoA09evxeY9ThrGkMz8pCUIfPdCHz/w0V90= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 54E2AF804F1; Thu, 15 Jul 2021 08:52:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C98DDF80254; Wed, 14 Jul 2021 12:27:15 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id E3A67F8013C for ; Wed, 14 Jul 2021 12:27:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E3A67F8013C Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2CFE91FB; Wed, 14 Jul 2021 03:27:00 -0700 (PDT) Received: from bogus (unknown [10.57.79.213]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2FF633F774; Wed, 14 Jul 2021 03:26:27 -0700 (PDT) Date: Wed, 14 Jul 2021 11:25:29 +0100 From: Sudeep Holla To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void Message-ID: <20210714102529.ehwquc2s2qlbccyg@bogus> References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Thu, 15 Jul 2021 08:52:27 +0200 Cc: nvdimm@lists.linux.dev, linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Samuel Iglesias Gonsalvez , Jens Taprogge , Ulf Hansson , linux-fpga@vger.kernel.org, Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Mike Christie , Wei Liu , Maxim Levitsky , Samuel Holland , Michael Ellerman , "Rafael J . Wysocki" , linux-acpi@vger.kernel.org, Geert Uytterhoeven , linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, Tomas Winkler , Julien Grall , Ohad Ben-Cohen , Yufen Yu , Alex Williamson , Alex Elder , linux-parisc@vger.kernel.org, Finn Thain , Geoff Levand , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Kai-Heng Feng , kernel@pengutronix.de, Jon Mason , linux-ntb@googlegroups.com, Wu Hao , David Woodhouse , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Alexandre Belloni , Manohar Vanga , linux-wireless@vger.kernel.org, Dominik Brodowski , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , target-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-s390@vger.kernel.org, Stefano Stabellini , Stephen Hemminger , Yoshinori Sato , Jiri Slaby , Helge Deller , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , YueHaibing , industrypack-devel@lists.sourceforge.net, linux-mips@vger.kernel.org, Len Brown , Vasily Gorbik , linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, Maxime Ripard , William Breathitt Gray , greybus-dev@lists.linaro.org, linux-m68k@lists.linux-m68k.org, Florian Fainelli , Rikard Falkeborn , Frank Li , Mark Gross , Boris Ostrovsky , Mika Westerberg , linux-arm-kernel@lists.infradead.org, Johannes Thumshirn , Mathieu Poirier , Stephen Boyd , Cornelia Huck , Peter Oberparleiter , Wolfram Sang , Joey Pabalan , Yehezkel Bernat , Pali =?utf-8?B?Um9ow6Fy?= , Bodo Stroesser , Alison Schofield , Heikki Krogerus , Tyrel Datwyler , Alexander Shishkin , Tom Rix , Jason Wang , SeongJae Park , alsa-devel@alsa-project.org, platform-driver-x86@vger.kernel.org, Bjorn Helgaas , netdev@vger.kernel.org, Vineeth Vijayan , Ira Weiny , Rob Herring , Lorenzo Pieralisi , Dave Jiang , linux-staging@lists.linux.dev, Dexuan Cui , Jernej Skrabec , Kishon Vijay Abraham I , Christian Borntraeger , Chen-Yu Tsai , linux-input@vger.kernel.org, Matt Porter , Allen Hubbe , Alex Dubov , Haiyang Zhang , Jiri Kosina , "Russell King \(Oracle\)" , Ben Widawsky , Harald Freudenberger , linux-cxl@vger.kernel.org, Michael Buesch , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , "Martin K. Petersen" , Martyn Welch , Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-sunxi@lists.linux.dev, Stefan Richter , Sudeep Holla , "David S. Miller" , Sven Van Asbroeck , Rich Felker , kvm@vger.kernel.org, "Michael S. Tsirkin" , linux-remoteproc@vger.kernel.org, Bjorn Andersson , sparclinux@vger.kernel.org, Kirti Wankhede , Andreas Noever , linux-i3c@lists.infradead.org, linux1394-devel@lists.sourceforge.net, Lee Jones , Arnd Bergmann , linux-scsi@vger.kernel.org, Marc Zyngier , Russell King , Thorsten Scherer , Andy Gross , linux-serial@vger.kernel.org, Jakub Kicinski , linux-hyperv@vger.kernel.org, Michael Jamet , Heiko Carstens , Johan Hovold , Hans de Goede , Hannes Reinecke , Juergen Gross , linuxppc-dev@lists.ozlabs.org, Takashi Iwai , Alexandre Bounine , Vinod Koul , Mark Brown , Vishal Verma , dmaengine@vger.kernel.org, Moritz Fischer , Johannes Berg , Johannes Thumshirn , Maximilian Luz X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > [...] > diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c > index 784cf0027da3..2682c3df651c 100644 > --- a/drivers/firmware/arm_scmi/bus.c > +++ b/drivers/firmware/arm_scmi/bus.c > @@ -116,15 +116,13 @@ static int scmi_dev_probe(struct device *dev) > return scmi_drv->probe(scmi_dev); > } > > -static int scmi_dev_remove(struct device *dev) > +static void scmi_dev_remove(struct device *dev) > { > struct scmi_driver *scmi_drv = to_scmi_driver(dev->driver); > struct scmi_device *scmi_dev = to_scmi_dev(dev); > > if (scmi_drv->remove) > scmi_drv->remove(scmi_dev); > - > - return 0; > } > > static struct bus_type scmi_bus_type = { Acked-by: Sudeep Holla -- Regards, Sudeep