alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding
       [not found] <20210721140424.725744-1-maxime@cerno.tech>
@ 2021-07-21 14:03 ` Maxime Ripard
  2021-07-23 21:32   ` Rob Herring
  2021-07-21 14:03 ` [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2021-07-21 14:03 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, devicetree,
	Rob Herring, Frank Rowand
  Cc: linux-sunxi, Mark Brown, alsa-devel, linux-arm-kernel,
	Liam Girdwood

Even though we had the wm8978 driver for some time and a number of
boards using it already, we never had a binding for it. Let's add it
based on what the driver expects and the boards are providing.

Cc: alsa-devel@alsa-project.org
Cc: devicetree@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../devicetree/bindings/sound/wlf,wm8978.yaml | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8978.yaml

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
new file mode 100644
index 000000000000..6761380261e3
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wolfson WM8978 Codec Device Tree Bindings
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  '#sound-dai-cells':
+    const: 0
+
+  compatible:
+    const: wlf,wm8978
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 526000
+
+required:
+  - '#sound-dai-cells'
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@0 {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0>;
+            spi-max-frequency = <500000>;
+        };
+    };
+
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@0 {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0>;
+        };
+    };
+
+...
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema
       [not found] <20210721140424.725744-1-maxime@cerno.tech>
  2021-07-21 14:03 ` [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
@ 2021-07-21 14:03 ` Maxime Ripard
  2021-07-22  5:35   ` Samuel Holland
  2021-07-21 14:03 ` [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
  2021-07-21 14:03 ` [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
  3 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2021-07-21 14:03 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, devicetree,
	Rob Herring, Frank Rowand
  Cc: alsa-devel, Samuel Holland, Liam Girdwood, linux-sunxi,
	Mark Brown, linux-arm-kernel

Bluetooth SCO Link are supported by Linux with a matching device tree
binding.

Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.

The value expected for #sound-dai-cells wasn't documented though, and
the users were inconsistent. The example didn't list it, and across the
4 users we have in tree:
  - 1 had a cells value of 1, but using only 0 as argument
  - 1 had a cells value of 0,
  - 2 didn't have this property at all, behaving as if it was 0,

It seems like the consensus seems to be that it should be 0, so let's
enforce it.

Cc: alsa-devel@alsa-project.org
Cc: devicetree@vger.kernel.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../devicetree/bindings/sound/bt-sco.txt      | 13 -------
 .../bindings/sound/linux,bt-sco.yaml          | 34 +++++++++++++++++++
 2 files changed, 34 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/bt-sco.txt
 create mode 100644 Documentation/devicetree/bindings/sound/linux,bt-sco.yaml

diff --git a/Documentation/devicetree/bindings/sound/bt-sco.txt b/Documentation/devicetree/bindings/sound/bt-sco.txt
deleted file mode 100644
index 641edf75e184..000000000000
--- a/Documentation/devicetree/bindings/sound/bt-sco.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-Bluetooth-SCO audio CODEC
-
-This device support generic Bluetooth SCO link.
-
-Required properties:
-
-  - compatible : "delta,dfbmcs320" or "linux,bt-sco"
-
-Example:
-
-codec: bt_sco {
-	compatible = "delta,dfbmcs320";
-};
diff --git a/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
new file mode 100644
index 000000000000..334b508205cd
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,bt-sco.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bluetooth SCO Audio Codec Device Tree Bindings
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  '#sound-dai-cells':
+    const: 0
+
+  compatible:
+    enum:
+      - delta,dfbmcs320
+      - linux,bt-sco
+
+required:
+  - '#sound-dai-cells'
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    codec {
+        #sound-dai-cells = <0>;
+        compatible = "linux,bt-sco";
+    };
+
+...
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter binding to a schema
       [not found] <20210721140424.725744-1-maxime@cerno.tech>
  2021-07-21 14:03 ` [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
  2021-07-21 14:03 ` [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
@ 2021-07-21 14:03 ` Maxime Ripard
  2021-07-23 21:35   ` Rob Herring
  2021-07-21 14:03 ` [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
  3 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2021-07-21 14:03 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, devicetree,
	Rob Herring, Frank Rowand
  Cc: linux-sunxi, Mark Brown, alsa-devel, linux-arm-kernel,
	Liam Girdwood

The SPDIF Transmitter binding is used by Linux with a matching Device
Tree binding.

Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.

Cc: alsa-devel@alsa-project.org
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../bindings/sound/linux,spdif-dit.yaml       | 32 +++++++++++++++++++
 .../bindings/sound/spdif-transmitter.txt      | 10 ------
 2 files changed, 32 insertions(+), 10 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/spdif-transmitter.txt

diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
new file mode 100644
index 000000000000..c6b070e1d014
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dummy SPDIF Transmitter Device Tree Bindings
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  compatible:
+    const: linux,spdif-dit
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - "#sound-dai-cells"
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    spdif-out {
+        #sound-dai-cells = <0>;
+        compatible = "linux,spdif-dit";
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
deleted file mode 100644
index 55a85841dd85..000000000000
--- a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-Device-Tree bindings for dummy spdif transmitter
-
-Required properties:
-	- compatible: should be "linux,spdif-dit".
-
-Example node:
-
-	codec: spdif-transmitter {
-		compatible = "linux,spdif-dit";
-	};
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier binding to a schema
       [not found] <20210721140424.725744-1-maxime@cerno.tech>
                   ` (2 preceding siblings ...)
  2021-07-21 14:03 ` [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
@ 2021-07-21 14:03 ` Maxime Ripard
  2021-07-23 21:36   ` Rob Herring
  3 siblings, 1 reply; 12+ messages in thread
From: Maxime Ripard @ 2021-07-21 14:03 UTC (permalink / raw)
  To: Chen-Yu Tsai, Maxime Ripard, Jernej Skrabec, devicetree,
	Rob Herring, Frank Rowand
  Cc: alsa-devel, Liam Girdwood, linux-sunxi, Mark Brown,
	linux-arm-kernel, Jerome Brunet

Simple audio amplifiers are supported by Linux with a matching device
tree binding.

Now that we have the DT validation in place, let's convert the device
tree bindings for that driver over to a YAML schema.

Cc: alsa-devel@alsa-project.org
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../bindings/sound/simple-amplifier.txt       | 17 -------
 .../sound/simple-audio-amplifier.yaml         | 45 +++++++++++++++++++
 2 files changed, 45 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt
 create mode 100644 Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml

diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt
deleted file mode 100644
index b1b097cc9b68..000000000000
--- a/Documentation/devicetree/bindings/sound/simple-amplifier.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Simple Amplifier Audio Driver
-
-Required properties:
-- compatible : "dioo,dio2125" or "simple-audio-amplifier"
-
-Optional properties:
-- enable-gpios : the gpio connected to the enable pin of the simple amplifier
-- VCC-supply   : power supply for the device, as covered
-                 in Documentation/devicetree/bindings/regulator/regulator.txt
-
-Example:
-
-amp: analog-amplifier {
-	compatible = "simple-audio-amplifier";
-	VCC-supply = <&regulator>;
-	enable-gpios = <&gpio GPIOH_3 0>;
-};
diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
new file mode 100644
index 000000000000..26379377a7ac
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/simple-audio-amplifier.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple Audio Amplifier Device Tree Bindings
+
+maintainers:
+  - Jerome Brunet <jbrunet@baylibre.com>
+
+properties:
+  compatible:
+    enum:
+      - dioo,dio2125
+      - simple-audio-amplifier
+
+  enable-gpios:
+    maxItems: 1
+
+  VCC-supply:
+    description: >
+      power supply for the device
+
+  sound-name-prefix:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: >
+      See ./name-prefix.txt
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/meson8-gpio.h>
+
+    analog-amplifier {
+        compatible = "simple-audio-amplifier";
+        VCC-supply = <&regulator>;
+        enable-gpios = <&gpio GPIOH_3 0>;
+    };
+
+...
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema
  2021-07-21 14:03 ` [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
@ 2021-07-22  5:35   ` Samuel Holland
  2021-07-22  7:58     ` Maxime Ripard
  0 siblings, 1 reply; 12+ messages in thread
From: Samuel Holland @ 2021-07-22  5:35 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, devicetree,
	Rob Herring, Frank Rowand
  Cc: linux-sunxi, Mark Brown, alsa-devel, linux-arm-kernel,
	Liam Girdwood

On 7/21/21 9:03 AM, Maxime Ripard wrote:
> Bluetooth SCO Link are supported by Linux with a matching device tree
> binding.
> 
> Now that we have the DT validation in place, let's convert the device
> tree bindings for that driver over to a YAML schema.
> 
> The value expected for #sound-dai-cells wasn't documented though, and
> the users were inconsistent. The example didn't list it, and across the
> 4 users we have in tree:
>   - 1 had a cells value of 1, but using only 0 as argument
>   - 1 had a cells value of 0,
>   - 2 didn't have this property at all, behaving as if it was 0,
> 
> It seems like the consensus seems to be that it should be 0, so let's
> enforce it.

The driver has two DAIs: "bt-sco-pcm" and "bt-sco-pcm-wb". If
#sound-dai-cells is 0, only the first DAI can be referenced from a
device tree. So to declare support for wideband PCM, or explicitly
declare a lack of support for it, #sound-dai-cells must be 1.

Regards,
Samuel

> Cc: alsa-devel@alsa-project.org
> Cc: devicetree@vger.kernel.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Samuel Holland <samuel@sholland.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/sound/bt-sco.txt      | 13 -------
>  .../bindings/sound/linux,bt-sco.yaml          | 34 +++++++++++++++++++
>  2 files changed, 34 insertions(+), 13 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/bt-sco.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/bt-sco.txt b/Documentation/devicetree/bindings/sound/bt-sco.txt
> deleted file mode 100644
> index 641edf75e184..000000000000
> --- a/Documentation/devicetree/bindings/sound/bt-sco.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Bluetooth-SCO audio CODEC
> -
> -This device support generic Bluetooth SCO link.
> -
> -Required properties:
> -
> -  - compatible : "delta,dfbmcs320" or "linux,bt-sco"
> -
> -Example:
> -
> -codec: bt_sco {
> -	compatible = "delta,dfbmcs320";
> -};
> diff --git a/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
> new file mode 100644
> index 000000000000..334b508205cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/linux,bt-sco.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bluetooth SCO Audio Codec Device Tree Bindings
> +
> +maintainers:
> +  - Mark Brown <broonie@kernel.org>
> +
> +properties:
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  compatible:
> +    enum:
> +      - delta,dfbmcs320
> +      - linux,bt-sco
> +
> +required:
> +  - '#sound-dai-cells'
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    codec {
> +        #sound-dai-cells = <0>;
> +        compatible = "linux,bt-sco";
> +    };
> +
> +...
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema
  2021-07-22  5:35   ` Samuel Holland
@ 2021-07-22  7:58     ` Maxime Ripard
  0 siblings, 0 replies; 12+ messages in thread
From: Maxime Ripard @ 2021-07-22  7:58 UTC (permalink / raw)
  To: Samuel Holland
  Cc: devicetree, Jernej Skrabec, alsa-devel, Mark Brown, linux-sunxi,
	Liam Girdwood, Chen-Yu Tsai, Rob Herring, Frank Rowand,
	linux-arm-kernel

Hi Samuel,

On Thu, Jul 22, 2021 at 12:35:33AM -0500, Samuel Holland wrote:
> On 7/21/21 9:03 AM, Maxime Ripard wrote:
> > Bluetooth SCO Link are supported by Linux with a matching device tree
> > binding.
> > 
> > Now that we have the DT validation in place, let's convert the device
> > tree bindings for that driver over to a YAML schema.
> > 
> > The value expected for #sound-dai-cells wasn't documented though, and
> > the users were inconsistent. The example didn't list it, and across the
> > 4 users we have in tree:
> >   - 1 had a cells value of 1, but using only 0 as argument
> >   - 1 had a cells value of 0,
> >   - 2 didn't have this property at all, behaving as if it was 0,
> > 
> > It seems like the consensus seems to be that it should be 0, so let's
> > enforce it.
> 
> The driver has two DAIs: "bt-sco-pcm" and "bt-sco-pcm-wb". If
> #sound-dai-cells is 0, only the first DAI can be referenced from a
> device tree. So to declare support for wideband PCM, or explicitly
> declare a lack of support for it, #sound-dai-cells must be 1.

Yeah, I knew there was something else to it :)

I'll fix it for the next iteration.

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding
  2021-07-21 14:03 ` [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
@ 2021-07-23 21:32   ` Rob Herring
  2021-07-26  0:17     ` Mark Brown
  0 siblings, 1 reply; 12+ messages in thread
From: Rob Herring @ 2021-07-23 21:32 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: devicetree, Jernej Skrabec, alsa-devel, linux-sunxi,
	Liam Girdwood, Chen-Yu Tsai, Mark Brown, Frank Rowand,
	linux-arm-kernel

On Wed, Jul 21, 2021 at 04:03:31PM +0200, Maxime Ripard wrote:
> Even though we had the wm8978 driver for some time and a number of
> boards using it already, we never had a binding for it. Let's add it
> based on what the driver expects and the boards are providing.
> 
> Cc: alsa-devel@alsa-project.org
> Cc: devicetree@vger.kernel.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../devicetree/bindings/sound/wlf,wm8978.yaml | 58 +++++++++++++++++++
>  1 file changed, 58 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
> new file mode 100644
> index 000000000000..6761380261e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Wolfson WM8978 Codec Device Tree Bindings
> +
> +maintainers:
> +  - Mark Brown <broonie@kernel.org>

No one from Wolfson cares about this device?

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> +properties:
> +  '#sound-dai-cells':
> +    const: 0
> +
> +  compatible:
> +    const: wlf,wm8978
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency:
> +    maximum: 526000
> +
> +required:
> +  - '#sound-dai-cells'
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@0 {
> +            #sound-dai-cells = <0>;
> +            compatible = "wlf,wm8978";
> +            reg = <0>;
> +            spi-max-frequency = <500000>;
> +        };
> +    };
> +
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@0 {
> +            #sound-dai-cells = <0>;
> +            compatible = "wlf,wm8978";
> +            reg = <0>;
> +        };
> +    };
> +
> +...
> -- 
> 2.31.1
> 
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter binding to a schema
  2021-07-21 14:03 ` [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
@ 2021-07-23 21:35   ` Rob Herring
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-07-23 21:35 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Jernej Skrabec, alsa-devel, devicetree, Liam Girdwood,
	Rob Herring, linux-sunxi, Mark Brown, Chen-Yu Tsai, Frank Rowand,
	linux-arm-kernel

On Wed, 21 Jul 2021 16:03:33 +0200, Maxime Ripard wrote:
> The SPDIF Transmitter binding is used by Linux with a matching Device
> Tree binding.
> 
> Now that we have the DT validation in place, let's convert the device
> tree bindings for that driver over to a YAML schema.
> 
> Cc: alsa-devel@alsa-project.org
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../bindings/sound/linux,spdif-dit.yaml       | 32 +++++++++++++++++++
>  .../bindings/sound/spdif-transmitter.txt      | 10 ------
>  2 files changed, 32 insertions(+), 10 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/spdif-transmitter.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier binding to a schema
  2021-07-21 14:03 ` [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
@ 2021-07-23 21:36   ` Rob Herring
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2021-07-23 21:36 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: devicetree, alsa-devel, linux-sunxi, Jernej Skrabec,
	Liam Girdwood, Rob Herring, Chen-Yu Tsai, Mark Brown,
	Frank Rowand, linux-arm-kernel, Jerome Brunet

On Wed, 21 Jul 2021 16:03:34 +0200, Maxime Ripard wrote:
> Simple audio amplifiers are supported by Linux with a matching device
> tree binding.
> 
> Now that we have the DT validation in place, let's convert the device
> tree bindings for that driver over to a YAML schema.
> 
> Cc: alsa-devel@alsa-project.org
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../bindings/sound/simple-amplifier.txt       | 17 -------
>  .../sound/simple-audio-amplifier.yaml         | 45 +++++++++++++++++++
>  2 files changed, 45 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/simple-amplifier.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding
  2021-07-23 21:32   ` Rob Herring
@ 2021-07-26  0:17     ` Mark Brown
  2021-07-27 12:21       ` Richard Fitzgerald
  0 siblings, 1 reply; 12+ messages in thread
From: Mark Brown @ 2021-07-26  0:17 UTC (permalink / raw)
  To: Rob Herring
  Cc: devicetree, Jernej Skrabec, alsa-devel, patches, linux-sunxi,
	Liam Girdwood, Chen-Yu Tsai, Maxime Ripard, Frank Rowand,
	linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 641 bytes --]

On Fri, Jul 23, 2021 at 03:32:51PM -0600, Rob Herring wrote:
> On Wed, Jul 21, 2021 at 04:03:31PM +0200, Maxime Ripard wrote:

> > Even though we had the wm8978 driver for some time and a number of
> > boards using it already, we never had a binding for it. Let's add it
> > based on what the driver expects and the boards are providing.

> > +maintainers:
> > +  - Mark Brown <broonie@kernel.org>

> No one from Wolfson cares about this device?

> Otherwise,

> Reviewed-by: Rob Herring <robh@kernel.org>

Well, Wolfson no longer exists since it was bought by Cirrus but copying
in the Cirrus people to see if they want to be listed there.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding
  2021-07-26  0:17     ` Mark Brown
@ 2021-07-27 12:21       ` Richard Fitzgerald
  2021-07-27 12:58         ` Mark Brown
  0 siblings, 1 reply; 12+ messages in thread
From: Richard Fitzgerald @ 2021-07-27 12:21 UTC (permalink / raw)
  To: Mark Brown, Rob Herring
  Cc: devicetree, Jernej Skrabec, alsa-devel, patches, Liam Girdwood,
	linux-sunxi, Maxime Ripard, Chen-Yu Tsai, Frank Rowand,
	linux-arm-kernel

On 26/07/2021 01:17, Mark Brown wrote:
> On Fri, Jul 23, 2021 at 03:32:51PM -0600, Rob Herring wrote:
>> On Wed, Jul 21, 2021 at 04:03:31PM +0200, Maxime Ripard wrote:
> 
>>> Even though we had the wm8978 driver for some time and a number of
>>> boards using it already, we never had a binding for it. Let's add it
>>> based on what the driver expects and the boards are providing.
> 
>>> +maintainers:
>>> +  - Mark Brown <broonie@kernel.org>
> 
>> No one from Wolfson cares about this device?
> 
>> Otherwise,
> 
>> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Well, Wolfson no longer exists since it was bought by Cirrus but copying
> in the Cirrus people to see if they want to be listed there.
> 

People, ownership, and email addresses can change. It's always best to
check MAINTAINERS to see the current support status. In this case it has
a section to pick up those Wolfson drivers, with the correct email
address. The list email will be monitored by multiple people.

WOLFSON MICROELECTRONICS DRIVERS
L:	patches@opensource.cirrus.com
S:	Supported
<SNIP>
F:	include/sound/wm????.h
<SNIP>
F:	sound/soc/codecs/wm*


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding
  2021-07-27 12:21       ` Richard Fitzgerald
@ 2021-07-27 12:58         ` Mark Brown
  0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2021-07-27 12:58 UTC (permalink / raw)
  To: Richard Fitzgerald
  Cc: Rob Herring, Jernej Skrabec, devicetree, patches, alsa-devel,
	Liam Girdwood, linux-sunxi, Maxime Ripard, Chen-Yu Tsai,
	Frank Rowand, linux-arm-kernel

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

On Tue, Jul 27, 2021 at 01:21:52PM +0100, Richard Fitzgerald wrote:
> On 26/07/2021 01:17, Mark Brown wrote:
> > On Fri, Jul 23, 2021 at 03:32:51PM -0600, Rob Herring wrote:
> > > On Wed, Jul 21, 2021 at 04:03:31PM +0200, Maxime Ripard wrote:

> > > > Even though we had the wm8978 driver for some time and a number of
> > > > boards using it already, we never had a binding for it. Let's add it
> > > > based on what the driver expects and the boards are providing.

> > > > +maintainers:
> > > > +  - Mark Brown <broonie@kernel.org>

> > > No one from Wolfson cares about this device?

> > > Otherwise,

> > > Reviewed-by: Rob Herring <robh@kernel.org>

> > Well, Wolfson no longer exists since it was bought by Cirrus but copying
> > in the Cirrus people to see if they want to be listed there.

> People, ownership, and email addresses can change. It's always best to
> check MAINTAINERS to see the current support status. In this case it has
> a section to pick up those Wolfson drivers, with the correct email
> address. The list email will be monitored by multiple people.
> 
> WOLFSON MICROELECTRONICS DRIVERS
> L:	patches@opensource.cirrus.com
> S:	Supported
> <SNIP>
> F:	include/sound/wm????.h
> <SNIP>
> F:	sound/soc/codecs/wm*

Might be worth updating that to cover the DT bindings too (Arizona is
the only sound driver for some reason, wm8974 already exists but is not
covered).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2021-07-27 12:59 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210721140424.725744-1-maxime@cerno.tech>
2021-07-21 14:03 ` [PATCH 01/54] ASoC: dt-bindings: Add WM8978 Binding Maxime Ripard
2021-07-23 21:32   ` Rob Herring
2021-07-26  0:17     ` Mark Brown
2021-07-27 12:21       ` Richard Fitzgerald
2021-07-27 12:58         ` Mark Brown
2021-07-21 14:03 ` [PATCH 02/54] ASoC: dt-bindings: Convert Bluetooth SCO Link binding to a schema Maxime Ripard
2021-07-22  5:35   ` Samuel Holland
2021-07-22  7:58     ` Maxime Ripard
2021-07-21 14:03 ` [PATCH 03/54] ASoC: dt-bindings: Convert SPDIF Transmitter " Maxime Ripard
2021-07-23 21:35   ` Rob Herring
2021-07-21 14:03 ` [PATCH 04/54] ASoC: dt-bindings: Convert Simple Amplifier " Maxime Ripard
2021-07-23 21:36   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).