Re: [PATCH v2 2/2] ASoC: codec: tlv320adc3xxx: New codec driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]

Hi Ricard,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on v5.15 next-20211101]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ricard-Wanderlof/Codec-driver-for-TLV320ADC3001-and-3101/20211101-175746
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: riscv-randconfig-r042-20211101 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/eefeedd45624e18f698bbbead028ab025018bbd1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ricard-Wanderlof/Codec-driver-for-TLV320ADC3001-and-3101/20211101-175746
        git checkout eefeedd45624e18f698bbbead028ab025018bbd1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/tlv320adc3xxx.c:244:5: warning: no previous prototype for 'adc3xxx_pll_delay' [-Wmissing-prototypes]
     244 | int adc3xxx_pll_delay(struct snd_soc_dapm_widget *w,
         |     ^~~~~~~~~~~~~~~~~
>> sound/soc/codecs/tlv320adc3xxx.c:834:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
     834 | static const char * const adc3xxx_pll_mode_text(int pll_mode)
         |        ^~~~~


vim +/adc3xxx_pll_delay +244 sound/soc/codecs/tlv320adc3xxx.c

   243	
 > 244	int adc3xxx_pll_delay(struct snd_soc_dapm_widget *w,
   245			      struct snd_kcontrol *kcontrol, int event)
   246	{
   247		/* 10msec delay needed after PLL power-up to allow
   248		 * PLL and dividers to stabilize (datasheet p13).
   249		 */
   250		usleep_range(10000, 20000);
   251	
   252		return 0;
   253	}
   254	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47631 bytes --]