From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32899C433F5 for ; Wed, 5 Jan 2022 09:59:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2D47F1743; Wed, 5 Jan 2022 10:58:46 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2D47F1743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1641376776; bh=QD/ShsKMMwqAMuRjkzxBlhWZEVjwwvOk67EVgctybq8=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VIwGgjZcaq0/vhTpYtwY3ECC9W0guD2lgLJIy1kMNQAr9lrO9biUUy69bIDtkOjo4 vW7Byx38qFrg7TFS2v90H0j8FyFDTPXTCd9WjedHHc2UlDhiXGdQjIhQuvQa2sbH2m Yc+nYq1WbgXhT5dDu2Hbg5pBrfVKgy2plTXImsDg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C2C5DF80167; Wed, 5 Jan 2022 10:58:45 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D5DE9F801D8; Wed, 5 Jan 2022 10:58:44 +0100 (CET) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D8C99F80089 for ; Wed, 5 Jan 2022 10:58:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D8C99F80089 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="hqSwsX9B" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 2058aLLs003317; Wed, 5 Jan 2022 03:58:36 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=MO2PSHj23wq8N+iVx3WZD17yLglCV3U38GihkcUa5JM=; b=hqSwsX9BwItRgwBU2nN+Ky5xxicAB+9sdIKfnsVe6wSEgUbaQEZaINAQZo+AlyRzKLxm Hdx8hRyS9uBv3NuiFssQ9vxMfgztWxRI/ZqlFbMNst7xUeb5JVBiE1m+Gj6mYTLGsufT zAlfysFSYqcY/JqHxLQAoGg8Rny2sRmqbChHW9r1te1+acwutJVtk4BGmfGg6m6sCGa2 xukKQTS4C+7lWz1wPwWFbNfpVnui64B3pap/bpzlUoa30LVaQiXswxQSFJORFNpx0ZsI 4AoGxsIdPTIxnbDdg3nw5Zob7tB1hFSg2EsgbeuKOqPbPCglYynK/7sfYsKMRFgglDBf Dg== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3dd7y3g262-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 05 Jan 2022 03:58:35 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 5 Jan 2022 09:58:34 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 5 Jan 2022 09:58:34 +0000 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 33897B0E; Wed, 5 Jan 2022 09:58:34 +0000 (UTC) Date: Wed, 5 Jan 2022 09:58:34 +0000 From: Charles Keepax To: Lucas Tanure Subject: Re: [PATCH v6 07/10] hda: cs35l41: Add support for CS35L41 in HDA systems Message-ID: <20220105095834.GD18506@ediswmail.ad.cirrus.com> References: <20211217115708.882525-1-tanureal@opensource.cirrus.com> <20211217115708.882525-8-tanureal@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20211217115708.882525-8-tanureal@opensource.cirrus.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-GUID: mQd4XZ9zG4wN_6-fzPf2Ov9s2DYnPmTR X-Proofpoint-ORIG-GUID: mQd4XZ9zG4wN_6-fzPf2Ov9s2DYnPmTR X-Proofpoint-Spam-Reason: safe Cc: alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, "Rafael J . Wysocki" , patches@opensource.cirrus.com, Takashi Iwai , Liam Girdwood , Mark Gross , Hans de Goede , Mark Brown , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Len Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Dec 17, 2021 at 11:57:05AM +0000, Lucas Tanure wrote: > Add support for CS35L41 using a new separated driver > that can be used in all upcoming designs > > Signed-off-by: Lucas Tanure > --- > + mtl_revid = reg_revid & CS35L41_MTLREVID_MASK; > + > + chipid = (mtl_revid % 2) ? CS35L41R_CHIP_ID : CS35L41_CHIP_ID; > + if (regid != chipid) { > + dev_err(cs35l41->dev, "CS35L41 Device ID (%X). Expected ID %X\n", regid, chipid); > + ret = -ENODEV; > + goto err; > + } > + > + ret = cs35l41_register_errata_patch(cs35l41->dev, cs35l41->regmap, reg_revid); > + if (ret) > + goto err; > + > + ret = cs35l41_otp_unpack(cs35l41->dev, cs35l41->regmap); > + if (ret) { > + dev_err(cs35l41->dev, "OTP Unpack failed: %d\n", ret); > + goto err; > + } > + > + ret = cs35l41_hda_apply_properties(cs35l41, acpi_hw_cfg); > + if (ret) > + goto err; > + kfree(acpi_hw_cfg); > + > + if (cs35l41->reg_seq->probe) { > + ret = regmap_register_patch(cs35l41->regmap, cs35l41->reg_seq->probe, > + cs35l41->reg_seq->num_probe); > + if (ret) { > + dev_err(cs35l41->dev, "Fail to apply probe reg patch: %d\n", ret); > + goto err; > + } > + } Probably shouldn't use regmap_register_patch here, cs35l41_register_errata_patch has already registered a patch to the regmap, and this will then overwrite that patch. Probably better to do this stuff as a multi-write. Thanks, Charles